Re: [PATCH] commit: teach --gpg-sign option
- From
Robin H. Johnson <robbat2@gentoo.org>
- Date
- Oct 6, 2011, 22:24 UTC
- Message-ID
- <robbat2-20111006T221637-481195848Z@orbis-terrarum.net>
- In-Reply-To
- <7vaa9f3pk8.fsf@alter.siamese.dyndns.org>
On Wed, Oct 05, 2011 at 05:56:55PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> And this uses the gpg-interface.[ch] to allow signing the commit, i.e. > > $ git commit --gpg-sign -m foo > You need a passphrase to unlock the secret key for > user: "Junio C Hamano <gitster@pobox.com>" > 4096-bit RSA key, ID 96AFE6CB, created 2011-10-03 (main key ID 713660A7) > > [master 8457d13] foo > 1 files changed, 1 insertions(+), 0 deletions(-)
I like it, but I have a couple of questions: 1. Are the sig lines used in computed SHA1/commitid of a given commit (I see examples w/ --amend and that would usually change the SHA1)? 2. Can we allow more than one person sign a commit? 3. If I have prepared a series on a local branch, and I want to sign all of them, is this a variant of rebase or?
I think this isn't a replacement for push certificates, but has value in itself. It's certainly provides better integration than the signature-in-note variants.
-- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85