Re: [PATCH] commit: teach --gpg-sign option

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2011, 16:35 UTC
Message-ID: <7vehykold0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4E9291B6.2090201@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 11 quoted lines

> Junio C Hamano venit, vidit, dixit 09.10.2011 23:22:
>> Michael J Gruber <git@drmicha.warpmail.net> writes:
>> 
>>> I just noticed that this format differs from the one of signed
>>> tags. What special reason is there for the "sig " indentation?
>> 
>> Read the part of the message you are quoting.
>
> I certainly did, and certainly did not find any mention. Do you think I
> would have asked otherwise? I'm trying to be helpful by testing out a
> patch in flight. That is: *I* am trying to be helpful.

Surely, sorry and thanks. I should have pointed out where I _thought_ I spelled out the reason but apparently in an ineffective way (as my wording did not convey what I wanted to say at least to you) a bit more clearly.

Show 7 quoted lines

> This
>> The lines of GPG detached signature are placed in new header lines, after
>> the standard tree/parent/author/committer headers, instead of tucking the
>> signature block at the end of the commit log message text (similar to how
>> signed tag is done), for multiple reasons:
> gave me the impression that commit signatures are done "similar to how
> signed tag is done".

Yeah, sorry if that sentence parses badly.

It was trying to say:

 - the sig is in header lines
   - which is different (instead of) from tucking it at the end of text
     - by the way that "tucking at the end" would have been similar to
       signed tag

The reasons why signatures in the header is better than tucking at the end are enumerated in the part you did not quote in this message but in the part you did quote in the previous message.