Re: Local unset override global options

From: Stefan Hajnoczi <stefanha@gmail.com>
Date: Apr 12, 2010, 08:43 UTC
Message-ID: <r2vfbd9d3991004120143td6f90410j60c7c002b15d5db6@mail.gmail.com>
In-Reply-To: <7vk4sdm5kw.fsf@alter.siamese.dyndns.org>

On Mon, Apr 12, 2010 at 9:35 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> @@ -1043,7 +1043,7 @@ X-Mailer: git-send-email $gitversion
>                            defined $smtp_server_port ? "port=$smtp_server_port" : "";
>                }
>
> -               if (defined $smtp_authuser) {
> +               if (defined $smtp_authuser && $smtp_authuser ne '') {
>
>                        if (!defined $smtp_authpass) {
>

That would work but introduces a special case for smtpuser. Do you think users may wish to unset override other options too?

Stefan