Re: Local unset override global options
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 12, 2010, 08:35 UTC
- Message-ID
- <7vk4sdm5kw.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4BC2D61B.7050902@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
> have you tried setting it to an empty value?
That sounds like a useful thing in general even outside override context. I however suspect that the code is not written carefully to check for empty string (which cannot possibly mean any valid username).
Perhaps we would need something like this.
git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index ce569a9..7c3f7c1 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1043,7 +1043,7 @@ X-Mailer: git-send-email $gitversion defined $smtp_server_port ? "port=$smtp_server_port" : ""; } - if (defined $smtp_authuser) { + if (defined $smtp_authuser && $smtp_authuser ne '') { if (!defined $smtp_authpass) {