Re: Local unset override global options

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2010, 18:18 UTC
Message-ID: <7vvdbwk004.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201004121902.08345.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 19 quoted lines

> Junio C Hamano wrote:
>> Jakub Narebski <jnareb@gmail.com> writes:
>> 
>> > How does special case of no value, i.e.
>> >
>> >    [sendemail]
>> >         smtpuser
>> 
>> That is not a special case; that is "boolean true".
>
> Well, it is "boolean true" *if* git-config is used with '--bool'.
>
> If git-send-email.perl used "git config -l -z" to read all its config 
> variables at once into hash, like gitweb.perl does in the 
> git_parse_project_config() subroutine, it would be able to distinguish 
> between those the case of no value:
>
>     [sendemail]
>          smtpuser

If sendemail is ever re-written in C and use git_config() API, the above will become boolean. Besides, even if you are sticking to sendemail.perl forever, you are still inventing another convention that "boolean true means no I don't want it". And it is clearly a lot less intuitive than "empty means no I don't want it", isn't it?