Re: [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template
- From
- Karl Chen <quarl@cs.berkeley.edu>
- Date
- Aug 29, 2008, 19:01 UTC
- Message-ID
- <quack.20080829T1201.lthsksnir1u@roar.cs.berkeley.edu>
- In-Reply-To
- <7vsksn4xdo.fsf@gitster.siamese.dyndns.org>
>>>>> On 2008-08-29 09:08 PDT, Junio C Hamano writes:
Junio> I do not see any strong reason why the single caller of
Junio> user_path() has to keep using the static allocation.
Junio> Would it help to reduce the complexity of your
Junio> expand_user_path() implementation, if we fixed the
Junio> caller along the lines of this patch (untested, but
Junio> just to illustrate the point)?Yes, expand_user_path() would be much simpler, it would basically be me original implementation except for returning NULL on error.