Re: [PATCH v2] Support "core.excludesfile = ~/.gitignore"

From: Jeff King <peff@peff.net>
Date: Aug 27, 2008, 00:25 UTC
Message-ID: <20080827002506.GB7347@coredump.intra.peff.net>
In-Reply-To: <quack.20080825T1207.lthk5e46hi4_-_@roar.cs.berkeley.edu>

On Mon, Aug 25, 2008 at 12:07:15PM -0700, Karl Chen wrote:

> Based on the discussion it sounds like there are complications to
> supporting relative paths (due to worktree config), and "$HOME"
> (when generalized, due to bootstrapping issues with $GIT_*).

I think that is fine for now. One other simple possibility would be to expand _just_ $HOME, and then if we later decided to do all environment variables it would naturally encompass that. However, we might want to support "~" then anyway, so I think doing "~" first is fine.

However, there are two problems with the patch:

  1. It should probably re-use path.c:user_path, as Johannes mentioned.

  2. There is no documentation update.

Also, are there any other config variables which would benefit from this substitution (I can't think of any off-hand, but there are quite a few I don't use).

-Peff