Re: [PATCH] git diff/diff-index/diff-files: call setup_work_tree()

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 25, 2008, 15:26 UTC
Message-ID: <fcaeb9bf0808250826l2f1a0f3l94fff1b702e69c5d@mail.gmail.com>
In-Reply-To: <1219677095-21732-1-git-send-email-vmiklos@frugalware.org>

On 8/25/08, Miklos Vajna <vmiklos@frugalware.org> wrote:

Show 15 quoted lines

>  diff --git a/builtin-diff.c b/builtin-diff.c
>
> index 7ffea97..57da6ed 100644
>
> --- a/builtin-diff.c
>  +++ b/builtin-diff.c
>
> @@ -279,6 +279,7 @@ int cmd_diff(int argc, const char **argv, const char *prefix)
>         diff_no_index(&rev, argc, argv, nongit, prefix);
>
>         /* Otherwise, we are doing the usual "git" diff */
>  +       setup_work_tree();
>         rev.diffopt.skip_stat_unmatch = !!diff_auto_refresh_index;
>
>         if (nongit)

At least builtin_diff_blobs() and builtin_diff_tree() won't need worktree, so NACK again. Anyway I'm not familiar with diff*. Junio should know these better.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.