git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] mingw: require Windows Vista or later (and fix the Windows CI builds)

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 3, 2018, 19:43 UTC
Message-ID
<pull.44.git.gitgitgadget@gmail.com>

I noticed that a recent GitGitGadget build failed in the Windows phase, with compat/poll/poll.h problems all over the place.

Turns out that this is caused by the recent upgrade of the mingw-w64 headers and crt files (7.0.0.5233.e0c09544 -> 7.0.0.5245.edf66197, which I assume now enforces Vista as minimal Windows version also for all mingw-w64 projects).

Luckily, in Git for Windows' master, we already had changes to require Vista (for unrelated reasons: to restrict the std handle inheritance when spawning new processes).

Technically, Windows Vista is already no longer supported [https://support.microsoft.com/en-us/help/22882/windows-vista-end-of-support] , but we do try to keep Git building on older Windows version, up until the point when it becomes too big of a maintenance burden.

Johannes Schindelin (3):
  compat/poll: prepare for targeting Windows Vista
  mingw: set _WIN32_WINNT explicitly for Git for Windows
  mingw: bump the minimum Windows version to Vista
 compat/poll/poll.c |  6 +++---
 compat/poll/poll.h | 15 +++++++++++++++
 config.mak.uname   |  4 ----
 git-compat-util.h  |  4 ++--
 4 files changed, 20 insertions(+), 9 deletions(-)
base-commit: fe8321ec057f9231c26c29b364721568e58040f7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-44%2Fdscho%2Frequire-windows-vista-or-later-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-44/dscho/require-windows-vista-or-later-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/44
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 9 in “mingw: require Windows Vista or later (and fix the Windows CI builds)”
  1. 0/3 mingw: require Windows Vista or later (and fix the Windows CI builds)Johannes Schindelin via GitGitGadget, Oct 3, 2018
  2. 1/3 compat/poll: prepare for targeting Windows VistaJohannes Schindelin via GitGitGadget, Oct 3, 2018
  3. 2/3 mingw: set _WIN32_WINNT explicitly for Git for WindowsJohannes Schindelin via GitGitGadget, Oct 3, 2018
  4. 3/3 mingw: bump the minimum Windows version to VistaJohannes Schindelin via GitGitGadget, Oct 3, 2018
  5. Ævar Arnfjörð BjarmasonOct 10, 2018
  6. Junio C HamanoOct 11, 2018
  7. Johannes SchindelinOct 14, 2019
  8. Johannes SchindelinOct 14, 2019
  9. Johannes SchindelinOct 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.