Re: [PATCH 3/3] mingw: bump the minimum Windows version to Vista

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 14, 2019, 11:54 UTC
Message-ID: <nycvar.QRO.7.76.6.1910141351580.46@tvgsbejvaqbjf.bet>
In-Reply-To: <87zhvlevxt.fsf@evledraar.gmail.com>

Hi Ævar,

[sorry about the blast from the past, I forgot to answer back then.]

On Wed, 10 Oct 2018, Ævar Arnfjörð Bjarmason wrote:

Show 29 quoted lines

> On Wed, Oct 03 2018, Johannes Schindelin via GitGitGadget wrote:
>
> > diff --git a/config.mak.uname b/config.mak.uname
> > index e47af72e01..8acdeb71fd 100644
> > --- a/config.mak.uname
> > +++ b/config.mak.uname
> > @@ -381,8 +381,6 @@ ifeq ($(uname_S),Windows)
> >  	NO_PYTHON = YesPlease
> >  	BLK_SHA1 = YesPlease
> >  	ETAGS_TARGET = ETAGS
> > -	NO_INET_PTON = YesPlease
> > -	NO_INET_NTOP = YesPlease
> >  	NO_POSIX_GOODIES = UnfortunatelyYes
> >  	NATIVE_CRLF = YesPlease
> >  	DEFAULT_HELP_FORMAT = html
> > @@ -529,8 +527,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
> >  	NO_REGEX = YesPlease
> >  	NO_PYTHON = YesPlease
> >  	ETAGS_TARGET = ETAGS
> > -	NO_INET_PTON = YesPlease
> > -	NO_INET_NTOP = YesPlease
> >  	NO_POSIX_GOODIES = UnfortunatelyYes
> >  	DEFAULT_HELP_FORMAT = html
> >  	COMPAT_CFLAGS += -DNOGDI -Icompat -Icompat/win32
>
> So before we were defining NO_INET_{PTON,NTOP} because XP needed it, but
> doing so on all Windows versions, is there other compat stuff there
> that's just catering to the lowest common denominator, and if so
> shouldn't that be version checked against the NT version?

I meant to reply much earlier: When I worked on this, I essentially went through all of the functions that we load dynamically on Windows, and I don't think I found any other pre-Vista support code to get rid of.

Thanks, Dscho