Re: [PATCH 3/3] mingw: bump the minimum Windows version to Vista

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 14, 2019, 11:46 UTC
Message-ID: <nycvar.QRO.7.76.6.1910141344160.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq8t35gfw2.fsf@gitster-ct.c.googlers.com>

Hi,

[sorry about the blast from the past, I just noticed that I had not answered]

On Thu, 11 Oct 2018, Junio C Hamano wrote:

Show 25 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
> >> It also means that we no longer need the inet_pton() and inet_ntop()
> >> emulation, which is nice.
> >
> > Earlier in this series you add a:
> >
> > #if defined(_WIN32_WINNT) && _WIN32_WINNT >= 0x600
> > ...
> > #endif
> >
> > Shouldn't that now be something like:
> >
> > #if defined(_WIN32_WINNT)
> > #if _WIN32_WINNT >= 0x600
> > ...
> > #else
> > #error "You need at least Windows Vista to build Git!"
> > #endif
> > #endif
> >
> > Or do we catch users building on non-supported versions earlier somehow
> > (i.e. not just with a flood of compilation errors).
>
> That sounds like a reasonable thing to be curious about.

I specifically wanted to leave the door open for people who might want to put in the effort of keeping Windows XP support alive.

But I guess this does not make any sense anymore, what with Windows _Vista_ being at its end of its life in 3 months.

Thanks! Will prepare a patch, Dscho

Show 6 quoted lines

>
> > Both of the above are just questions I was curious about since I saw
> > your <nycvar.QRO.7.76.6.1810101502220.2034@tvgsbejvaqbjf.bet>, and
> > shouldn't bee seen as bumping this to "this needs a re-roll" or it
> > should be delayed in getting to master.
>