git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] Define GIT_TEST_COMMIT_GRAPH for commit-graph test coverage

From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 28, 2018, 20:33 UTC
Message-ID
<pull.26.git.gitgitgadget@gmail.com>

The commit-graph (and multi-pack-index) features are optional data structures that can make Git operations faster. Since they are optional, we do not enable them in most Git tests. The commit-graph is tested in t5318-commit-graph.sh (and t6600-test-reach.sh in ds/reachable), but that one script cannot cover the data shapes present in the rest of the test suite.

This patch introduces a new test environment variable, GIT_TEST_COMMIT_GRAPH . Similar to GIT_TEST_SPLIT_INDEX, it enables the commit-graph and writes it with every git commit command. Thanks, Duy, for pointing out this direction [1].

A few tests needed to be modified. These are the same tests that were mentioned in my previous example patch [2].

When this merges down, I'll create a CI build in VSTS that runs the test suite with this option enabled.

Thanks, -Stolee
[1] 
https://public-inbox.org/git/CACsJy8CKnXVJYkKM_W=N=Vq-TVXf+YCqZP_uP7B-dN_6xddB=g@mail.gmail.com/
Re: [PATCH 0/9] multi-pack-index cleanups (Discussing test environment
variables)

[2] https://public-inbox.org/git/20180718152244.45513-1-dstolee@microsoft.com/ [PATCH] DO-NOT-MERGE: write and read commit-graph always

Based-On: ds/commit-graph-with-grafts Cc: jnareb@gmail.com
Derrick Stolee (1):
  commit-graph: define GIT_TEST_COMMIT_GRAPH
 builtin/commit.c                    |  4 ++++
 commit-graph.c                      |  5 +++--
 commit-graph.h                      |  2 ++
 t/README                            |  4 ++++
 t/t0410-partial-clone.sh            |  2 +-
 t/t5307-pack-missing-commit.sh      | 10 ++++++++--
 t/t6011-rev-list-with-bad-commit.sh | 10 ++++++----
 t/t6024-recursive-merge.sh          |  9 ++++++---
 8 files changed, 34 insertions(+), 12 deletions(-)
base-commit: 829a321569d8e8f2c582aef9f0c990df976ab842
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-26%2Fderrickstolee%2Fshallow%2Ftest-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-26/derrickstolee/shallow/test-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/26
-- 
gitgitgadget
Next: Derrick Stolee via GitGitGadget
Message 1 of 18 in “Define GIT_TEST_COMMIT_GRAPH for commit-graph test coverage”
  1. 0/1 Define GIT_TEST_COMMIT_GRAPH for commit-graph test coverageDerrick Stolee via GitGitGadget, Aug 28, 2018
  2. 1/1 commit-graph: define GIT_TEST_COMMIT_GRAPHDerrick Stolee via GitGitGadget, Aug 28, 2018
  3. Stefan BellerAug 28, 2018
  4. Derrick StoleeAug 28, 2018
  5. Eric SunshineAug 28, 2018
  6. Derrick StoleeAug 29, 2018
  7. Ævar Arnfjörð BjarmasonOct 8, 2018
  8. Derrick StoleeOct 8, 2018
  9. Ævar Arnfjörð BjarmasonOct 8, 2018
  10. Derrick StoleeOct 8, 2018
  11. Junio C HamanoOct 9, 2018
  12. Stefan BellerAug 28, 2018
  13. Derrick StoleeAug 28, 2018
  14. 0/1 Define GIT_TEST_COMMIT_GRAPH for commit-graph test coverageDerrick Stolee via GitGitGadget, Aug 29, 2018
  15. 1/1 commit-graph: define GIT_TEST_COMMIT_GRAPHDerrick Stolee via GitGitGadget, Aug 29, 2018
  16. Duy NguyenSep 4, 2018
  17. Derrick StoleeSep 4, 2018
  18. Duy NguyenSep 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.