Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 28, 2018, 21:59 UTC
Message-ID: <CAPig+cSjanDi=jV75PdzYpAjwVgd4Suh3UyvY+Vy7yeHAuY8RA@mail.gmail.com>
In-Reply-To: <3bb1d527-87ae-5fdb-be9a-b83f6a68d3a0@gmail.com>

On Tue, Aug 28, 2018 at 5:31 PM Derrick Stolee <stolee@gmail.com> wrote:

Show 10 quoted lines

> On 8/28/2018 4:41 PM, Stefan Beller wrote:
> > On Tue, Aug 28, 2018 at 1:33 PM Derrick Stolee via GitGitGadget
> > <gitgitgadget@gmail.com> wrote:
> >> +               GIT_TEST_COMMIT_GRAPH=0 &&
> >> +               test_must_fail git merge -m final G
> > This could go on the same line without the && in between, setting the
> > variable as a prefix.
>
> It cannot! The Linux build I ran complained that you can't put
> environment variables through test_must_fail.

Is GIT_TEST_COMMIT_GRAPH exported? If not, it won't have an impact on git-merge anyhow.

As for the special case of one-shot environment variable and test_must_fail(), you'll find "env" used as a workaround in a number of tests:

    test_must_fail env GIT_TEST_COMMIT_GRAPH=0 git merge ... &&