Re: [PATCH 0/1] Define GIT_TEST_COMMIT_GRAPH for commit-graph test coverage
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Aug 28, 2018, 21:32 UTC
- Message-ID
- <42231d43-c1f7-592f-cec8-0b07eb9f70bc@gmail.com>
- In-Reply-To
- <CAGZ79kZ=jsCmxKdcPB+Q1__uO8Z2tXx6OkdyTSM8P3QdNGpKQA@mail.gmail.com>
On 8/28/2018 4:37 PM, Stefan Beller wrote:
Show 15 quoted lines
> On Tue, Aug 28, 2018 at 1:33 PM Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> The commit-graph (and multi-pack-index) features are optional data >> structures that can make Git operations faster. Since they are optional, we >> do not enable them in most Git tests. The commit-graph is tested in >> t5318-commit-graph.sh (and t6600-test-reach.sh in ds/reachable), but that >> one script cannot cover the data shapes present in the rest of the test >> suite. >> >> This patch introduces a new test environment variable, GIT_TEST_COMMIT_GRAPH >> . Similar to GIT_TEST_SPLIT_INDEX, it enables the commit-graph and writes it >> with every git commit command. >> Thanks, Duy, for pointing out this direction > Did you mean to cc Duy (instead of me)? > (I'll happily review the patch, too... just asking)
I just added you because you've been on a lot of commit-graph things lately. But yes, I forgot to add Duy to the CC list. Added to this message.
Thanks,
-Stolee