git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 08/28] Provide zlib's uncompress2 from compat/zlib-compat.c

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 23, 2021, 12:12 UTC
Message-ID
<patch-v4-08.28-e2f2729443b-20210823T120208Z-avarab@gmail.com>
In-Reply-To
<cover-v4-00.28-00000000000-20210823T120208Z-avarab@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>
This will be needed for reading reflog blocks in reftable.
Helped-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 Makefile                  |  7 +++
 ci/lib.sh                 |  1 +
 compat/.gitattributes     |  1 +
 compat/zlib-uncompress2.c | 92 +++++++++++++++++++++++++++++++++++++++
 config.mak.uname          |  1 +
 configure.ac              | 13 ++++++
 6 files changed, 115 insertions(+)
 create mode 100644 compat/.gitattributes
 create mode 100644 compat/zlib-uncompress2.c
diff --git a/Makefile b/Makefile
index e98d8ed17cf..16c883978d4 100644
--- a/Makefile
+++ b/Makefile
@@ -256,6 +256,8 @@ all::
 #
 # Define NO_DEFLATE_BOUND if your zlib does not have deflateBound.
 #
+# Define NO_UNCOMPRESS2 if your zlib does not have uncompress2.
+#
 # Define NO_NORETURN if using buggy versions of gcc 4.6+ and profile feedback,
 # as the compiler can crash (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49299)
 #
@@ -1738,6 +1740,11 @@ ifdef NO_DEFLATE_BOUND
 	BASIC_CFLAGS += -DNO_DEFLATE_BOUND
 endif
 
+ifdef NO_UNCOMPRESS2
+	BASIC_CFLAGS += -DNO_UNCOMPRESS2
+	REFTABLE_OBJS += compat/zlib-uncompress2.o
+endif
+
 ifdef NO_POSIX_GOODIES
 	BASIC_CFLAGS += -DNO_POSIX_GOODIES
 endif
diff --git a/ci/lib.sh b/ci/lib.sh
index 476c3f369f5..5711c63979d 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -224,6 +224,7 @@ linux-gcc-default)
 	;;
 Linux32)
 	CC=gcc
+	MAKEFLAGS="$MAKEFLAGS NO_UNCOMPRESS2=1"
 	;;
 linux-musl)
 	CC=gcc
diff --git a/compat/.gitattributes b/compat/.gitattributes
new file mode 100644
index 00000000000..40dbfb170da
--- /dev/null
+++ b/compat/.gitattributes
@@ -0,0 +1 @@
+/zlib-uncompress2.c	whitespace=-indent-with-non-tab,-trailing-space
diff --git a/compat/zlib-uncompress2.c b/compat/zlib-uncompress2.c
new file mode 100644
index 00000000000..6893bb469ce
--- /dev/null
+++ b/compat/zlib-uncompress2.c
@@ -0,0 +1,92 @@
+/* taken from zlib's uncompr.c
+
+   commit cacf7f1d4e3d44d871b605da3b647f07d718623f
+   Author: Mark Adler <madler@alumni.caltech.edu>
+   Date:   Sun Jan 15 09:18:46 2017 -0800
+
+       zlib 1.2.11
+
+*/
+
+/*
+ * Copyright (C) 1995-2003, 2010, 2014, 2016 Jean-loup Gailly, Mark Adler
+ * For conditions of distribution and use, see copyright notice in zlib.h
+ */
+
+#include <zlib.h>
+
+/* clang-format off */
+
+/* ===========================================================================
+     Decompresses the source buffer into the destination buffer.  *sourceLen is
+   the byte length of the source buffer. Upon entry, *destLen is the total size
+   of the destination buffer, which must be large enough to hold the entire
+   uncompressed data. (The size of the uncompressed data must have been saved
+   previously by the compressor and transmitted to the decompressor by some
+   mechanism outside the scope of this compression library.) Upon exit,
+   *destLen is the size of the decompressed data and *sourceLen is the number
+   of source bytes consumed. Upon return, source + *sourceLen points to the
+   first unused input byte.
+
+     uncompress returns Z_OK if success, Z_MEM_ERROR if there was not enough
+   memory, Z_BUF_ERROR if there was not enough room in the output buffer, or
+   Z_DATA_ERROR if the input data was corrupted, including if the input data is
+   an incomplete zlib stream.
+*/
+int ZEXPORT uncompress2 (
+    Bytef *dest,
+    uLongf *destLen,
+    const Bytef *source,
+    uLong *sourceLen) {
+    z_stream stream;
+    int err;
+    const uInt max = (uInt)-1;
+    uLong len, left;
+    Byte buf[1];    /* for detection of incomplete stream when *destLen == 0 */
+
+    len = *sourceLen;
+    if (*destLen) {
+        left = *destLen;
+        *destLen = 0;
+    }
+    else {
+        left = 1;
+        dest = buf;
+    }
+
+    stream.next_in = (z_const Bytef *)source;
+    stream.avail_in = 0;
+    stream.zalloc = (alloc_func)0;
+    stream.zfree = (free_func)0;
+    stream.opaque = (voidpf)0;
+
+    err = inflateInit(&stream);
+    if (err != Z_OK) return err;
+
+    stream.next_out = dest;
+    stream.avail_out = 0;
+
+    do {
+        if (stream.avail_out == 0) {
+            stream.avail_out = left > (uLong)max ? max : (uInt)left;
+            left -= stream.avail_out;
+        }
+        if (stream.avail_in == 0) {
+            stream.avail_in = len > (uLong)max ? max : (uInt)len;
+            len -= stream.avail_in;
+        }
+        err = inflate(&stream, Z_NO_FLUSH);
+    } while (err == Z_OK);
+
+    *sourceLen -= len + stream.avail_in;
+    if (dest != buf)
+        *destLen = stream.total_out;
+    else if (stream.total_out && err == Z_BUF_ERROR)
+        left = 1;
+
+    inflateEnd(&stream);
+    return err == Z_STREAM_END ? Z_OK :
+           err == Z_NEED_DICT ? Z_DATA_ERROR  :
+           err == Z_BUF_ERROR && left + stream.avail_out ? Z_DATA_ERROR :
+           err;
+}
diff --git a/config.mak.uname b/config.mak.uname
index 69413fb3dc0..61e11550b1f 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -256,6 +256,7 @@ ifeq ($(uname_S),FreeBSD)
 	FILENO_IS_A_MACRO = UnfortunatelyYes
 endif
 ifeq ($(uname_S),OpenBSD)
+	NO_UNCOMPRESS2 = YesPlease
 	NO_STRCASESTR = YesPlease
 	NO_MEMMEM = YesPlease
 	USE_ST_TIMESPEC = YesPlease
diff --git a/configure.ac b/configure.ac
index 031e8d3fee8..c3a913103d0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -672,9 +672,22 @@ AC_LINK_IFELSE([ZLIBTEST_SRC],
 	NO_DEFLATE_BOUND=yes])
 LIBS="$old_LIBS"
 
+AC_DEFUN([ZLIBTEST_UNCOMPRESS2_SRC], [
+AC_LANG_PROGRAM([#include <zlib.h>],
+ [uncompress2(NULL,NULL,NULL,NULL);])])
+AC_MSG_CHECKING([for uncompress2 in -lz])
+old_LIBS="$LIBS"
+LIBS="$LIBS -lz"
+AC_LINK_IFELSE([ZLIBTEST_UNCOMPRESS2_SRC],
+	[AC_MSG_RESULT([yes])],
+	[AC_MSG_RESULT([no])
+	NO_UNCOMPRESS2=yes])
+LIBS="$old_LIBS"
+
 GIT_UNSTASH_FLAGS($ZLIB_PATH)
 
 GIT_CONF_SUBST([NO_DEFLATE_BOUND])
+GIT_CONF_SUBST([NO_UNCOMPRESS2])
 
 #
 # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,
-- 
2.33.0.662.gbaddc25a55e
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 101 of 132 in “Support reftable ref backend for Git”
  1. 00/26 Support reftable ref backend for GitHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  2. 01/26 hash.h: provide constants for the hash IDsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  3. 02/26 init-db: set the_repository->hash_algo early onHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  4. 03/26 reftable: RFC: add LICENSEHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  5. 06/26 reftable: add blocksource, an abstraction for random access readsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  6. 04/26 reftable: add error related functionalityHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  7. 05/26 reftable: utility functionsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  8. 08/26 Provide zlib's uncompress2 from compat/zlib-compat.cHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  9. 07/26 reftable: (de)serialization for the polymorphic record type.Han-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  10. 10/26 reftable: a generic binary tree implementationHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  11. 13/26 reftable: read reftable filesHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  12. 15/26 reftable: add a heap-based priority queue for reftable recordsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  13. 09/26 reftable: reading/writing blocksHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  14. 12/26 reftable: generic interface to tablesHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  15. 14/26 reftable: reftable file level testsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  16. 11/26 reftable: write reftable filesHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  17. 19/26 reftable: add dump utilityHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  18. 17/26 reftable: implement refname validationHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  19. 16/26 reftable: add merged table viewHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  20. 20/26 refs: RFC: Reftable support for git-coreHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  21. 24/26 t1401,t2011: parameterize HEAD.lock for REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  22. 23/26 t1301: document what needs to be done for reftableHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  23. 26/26 t7004: avoid direct filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  24. 25/26 t1404: annotate test cases with REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  25. 21/26 git-prompt: prepare for reftable refs backendSZEDER Gábor via GitGitGadget, Jul 20, 2021
  26. 18/26 reftable: implement stack, a mutable database of reftable files.Han-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  27. 22/26 Add "test-tool dump-reftable" command.Han-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  28. 00/25 Support reftable ref backend for GitHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  29. 01/25 hash.h: provide constants for the hash IDsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  30. 02/25 init-db: set the_repository->hash_algo early onHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  31. 03/25 reftable: RFC: add LICENSEHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  32. 04/25 reftable: add error related functionalityHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  33. 05/25 reftable: utility functionsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  34. 06/25 reftable: add blocksource, an abstraction for random access readsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  35. 08/25 Provide zlib's uncompress2 from compat/zlib-compat.cHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  36. 07/25 reftable: (de)serialization for the polymorphic record type.Han-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  37. Carlo Marcelo Arenas BelónAug 16, 2021
  38. Han-Wen NienhuysAug 17, 2021
  39. 09/25 reftable: reading/writing blocksHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  40. 10/25 reftable: a generic binary tree implementationHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  41. 11/25 reftable: write reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  42. 12/25 reftable: generic interface to tablesHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  43. 13/25 reftable: read reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  44. 14/25 reftable: reftable file level testsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  45. 15/25 reftable: add a heap-based priority queue for reftable recordsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  46. 16/25 reftable: add merged table viewHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  47. 17/25 reftable: implement refname validationHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  48. 18/25 reftable: implement stack, a mutable database of reftable files.Han-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  49. 19/25 reftable: add dump utilityHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  50. 21/25 git-prompt: prepare for reftable refs backendSZEDER Gábor via GitGitGadget, Aug 16, 2021
  51. 20/25 refs: RFC: Reftable support for git-coreHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  52. 22/25 Add "test-tool dump-reftable" command.Han-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  53. 23/25 t1301: document what needs to be done for reftableHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  54. 24/25 t1401,t2011: parameterize HEAD.lock for REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  55. 25/25 t1404: annotate test cases with REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  56. Junio C HamanoAug 16, 2021
  57. Han-Wen NienhuysAug 17, 2021
  58. 00/25 Support reftable ref backend for GitHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  59. 01/25 hash.h: provide constants for the hash IDsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  60. Ævar Arnfjörð BjarmasonAug 23, 2021
  61. 06/25 reftable: add blocksource, an abstraction for random access readsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  62. 08/25 Provide zlib's uncompress2 from compat/zlib-compat.cHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  63. Philip OakleyAug 18, 2021
  64. Han-Wen NienhuysAug 18, 2021
  65. Philip OakleyAug 18, 2021
  66. 09/25 reftable: reading/writing blocksHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  67. 05/25 reftable: utility functionsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  68. 03/25 reftable: RFC: add LICENSEHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  69. 04/25 reftable: add error related functionalityHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  70. 12/25 reftable: generic interface to tablesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  71. 07/25 reftable: (de)serialization for the polymorphic record type.Han-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  72. 11/25 reftable: write reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  73. 10/25 reftable: a generic binary tree implementationHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  74. 21/25 git-prompt: prepare for reftable refs backendSZEDER Gábor via GitGitGadget, Aug 17, 2021
  75. 20/25 refs: RFC: Reftable support for git-coreHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  76. Ævar Arnfjörð BjarmasonAug 23, 2021
  77. Han-Wen NienhuysAug 30, 2021
  78. Ævar Arnfjörð BjarmasonAug 30, 2021
  79. 19/25 reftable: add dump utilityHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  80. 15/25 reftable: add a heap-based priority queue for reftable recordsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  81. 13/25 reftable: read reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  82. 25/25 t1404: annotate test cases with REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  83. 16/25 reftable: add merged table viewHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  84. 18/25 reftable: implement stack, a mutable database of reftable files.Han-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  85. 24/25 t1401,t2011: parameterize HEAD.lock for REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  86. 22/25 Add "test-tool dump-reftable" command.Han-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  87. 17/25 reftable: implement refname validationHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  88. 23/25 t1301: document what needs to be done for reftableHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  89. 14/25 reftable: reftable file level testsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  90. 02/25 init-db: set the_repository->hash_algo early onHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  91. Ævar Arnfjörð BjarmasonAug 23, 2021
  92. Ævar Arnfjörð BjarmasonAug 26, 2021
  93. 00/28 Support reftable ref backend for GitÆvar Arnfjörð Bjarmason, Aug 23, 2021
  94. 01/28 hash.h: provide constants for the hash IDsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  95. 02/28 init-db: set the_repository->hash_algo early onÆvar Arnfjörð Bjarmason, Aug 23, 2021
  96. 03/28 reftable: RFC: add LICENSEÆvar Arnfjörð Bjarmason, Aug 23, 2021
  97. 04/28 reftable: add error related functionalityÆvar Arnfjörð Bjarmason, Aug 23, 2021
  98. 05/28 reftable: utility functionsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  99. 06/28 reftable: add blocksource, an abstraction for random access readsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  100. 07/28 reftable: (de)serialization for the polymorphic record type.Ævar Arnfjörð Bjarmason, Aug 23, 2021
  101. 08/28 Provide zlib's uncompress2 from compat/zlib-compat.cÆvar Arnfjörð Bjarmason, Aug 23, 2021
  102. 09/28 reftable: reading/writing blocksÆvar Arnfjörð Bjarmason, Aug 23, 2021
  103. 10/28 reftable: a generic binary tree implementationÆvar Arnfjörð Bjarmason, Aug 23, 2021
  104. 12/28 reftable: generic interface to tablesÆvar Arnfjörð Bjarmason, Aug 23, 2021
  105. 13/28 reftable: read reftable filesÆvar Arnfjörð Bjarmason, Aug 23, 2021
  106. 14/28 reftable: reftable file level testsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  107. 15/28 reftable: add a heap-based priority queue for reftable recordsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  108. 16/28 reftable: add merged table viewÆvar Arnfjörð Bjarmason, Aug 23, 2021
  109. 17/28 reftable: implement refname validationÆvar Arnfjörð Bjarmason, Aug 23, 2021
  110. 19/28 reftable: add dump utilityÆvar Arnfjörð Bjarmason, Aug 23, 2021
  111. 18/28 reftable: implement stack, a mutable database of reftable files.Ævar Arnfjörð Bjarmason, Aug 23, 2021
  112. Junio C HamanoAug 27, 2021
  113. reftable: fixup for broken __FUNCTION__ useÆvar Arnfjörð Bjarmason, Aug 27, 2021
  114. Carlo ArenasAug 27, 2021
  115. Han-Wen NienhuysAug 30, 2021
  116. 21/28 git-prompt: prepare for reftable refs backendÆvar Arnfjörð Bjarmason, Aug 23, 2021
  117. 20/28 refs: RFC: Reftable support for git-coreÆvar Arnfjörð Bjarmason, Aug 23, 2021
  118. 22/28 Add "test-tool dump-reftable" command.Ævar Arnfjörð Bjarmason, Aug 23, 2021
  119. 23/28 t1301: document what needs to be done for reftableÆvar Arnfjörð Bjarmason, Aug 23, 2021
  120. 26/28 reftable: fixup for new base topic 1/3Ævar Arnfjörð Bjarmason, Aug 23, 2021
  121. 25/28 t1404: annotate test cases with REFFILESÆvar Arnfjörð Bjarmason, Aug 23, 2021
  122. 24/28 t1401,t2011: parameterize HEAD.lock for REFFILESÆvar Arnfjörð Bjarmason, Aug 23, 2021
  123. 27/28 reftable: fixup for new base topic 2/3Ævar Arnfjörð Bjarmason, Aug 23, 2021
  124. Han-Wen NienhuysAug 30, 2021
  125. Ævar Arnfjörð BjarmasonAug 30, 2021
  126. Han-Wen NienhuysAug 30, 2021
  127. Ævar Arnfjörð BjarmasonAug 30, 2021
  128. 28/28 reftable: fixup for new base topic 3/3Ævar Arnfjörð Bjarmason, Aug 23, 2021
  129. 11/28 reftable: write reftable filesÆvar Arnfjörð Bjarmason, Aug 23, 2021
  130. Junio C HamanoAug 26, 2021
  131. Han-Wen NienhuysAug 26, 2021
  132. Junio C HamanoAug 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.