Re: [PATCH v3 08/25] Provide zlib's uncompress2 from compat/zlib-compat.c
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Aug 18, 2021, 10:39 UTC
- Message-ID
- <CAFQ2z_P1EnNYPxiTZ8GeTTVsJaa0S0vz5M4kqu7Kf3yGbUt0kQ@mail.gmail.com>
- In-Reply-To
- <e1959ed9-beed-f110-c9a8-da8ed352dcda@iee.email>
On Wed, Aug 18, 2021 at 12:14 PM Philip Oakley <philipoakley@iee.email> wrote:
Show 8 quoted lines
> > On 17/08/2021 14:39, Han-Wen Nienhuys via GitGitGadget wrote: > > From: Han-Wen Nienhuys <hanwen@google.com> > > > > This will be needed for reading reflog blocks in reftable. > > How large might the reftable become? In particular will it exceed the > 32bit Long limit on Windows?
A reftable file is organized as a sequence of blocks. Each block has max size 2^24, and the zlib compression is done per-block. So zlib should not introduce a new 4G limit. The intra-file offsets for the blocks themselves are encoded either as varint (index values) or as uint64 (file footer), so reftable files beyond 4G should be no problem.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado