git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 04/25] reftable: add error related functionality

From
Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 16, 2021, 20:16 UTC
Message-ID
<75864034af2b2671697cad92f10a3335dc841b1e.1629145036.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1054.v2.git.git.1629145036.gitgitgadget@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>

The reftable/ directory is structured as a library, so it cannot crash on misuse. Instead, it returns an error codes.

In addition, the error code can be used to signal conditions from lower levels of the library to be handled by higher levels of the library. For example, a transaction might legitimately write an empty reftable file, but in that case, we'd want to shortcut the transaction overhead.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 reftable/error.c          | 41 ++++++++++++++++++++++++++
 reftable/reftable-error.h | 62 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 103 insertions(+)
 create mode 100644 reftable/error.c
 create mode 100644 reftable/reftable-error.h
diff --git a/reftable/error.c b/reftable/error.c
new file mode 100644
index 00000000000..f6f16def921
--- /dev/null
+++ b/reftable/error.c
@@ -0,0 +1,41 @@
+/*
+Copyright 2020 Google LLC
+
+Use of this source code is governed by a BSD-style
+license that can be found in the LICENSE file or at
+https://developers.google.com/open-source/licenses/bsd
+*/
+
+#include "reftable-error.h"
+
+#include <stdio.h>
+
+const char *reftable_error_str(int err)
+{
+	static char buf[250];
+	switch (err) {
+	case REFTABLE_IO_ERROR:
+		return "I/O error";
+	case REFTABLE_FORMAT_ERROR:
+		return "corrupt reftable file";
+	case REFTABLE_NOT_EXIST_ERROR:
+		return "file does not exist";
+	case REFTABLE_LOCK_ERROR:
+		return "data is outdated";
+	case REFTABLE_API_ERROR:
+		return "misuse of the reftable API";
+	case REFTABLE_ZLIB_ERROR:
+		return "zlib failure";
+	case REFTABLE_NAME_CONFLICT:
+		return "file/directory conflict";
+	case REFTABLE_EMPTY_TABLE_ERROR:
+		return "wrote empty table";
+	case REFTABLE_REFNAME_ERROR:
+		return "invalid refname";
+	case -1:
+		return "general error";
+	default:
+		snprintf(buf, sizeof(buf), "unknown error code %d", err);
+		return buf;
+	}
+}
diff --git a/reftable/reftable-error.h b/reftable/reftable-error.h
new file mode 100644
index 00000000000..6f89bedf1a5
--- /dev/null
+++ b/reftable/reftable-error.h
@@ -0,0 +1,62 @@
+/*
+Copyright 2020 Google LLC
+
+Use of this source code is governed by a BSD-style
+license that can be found in the LICENSE file or at
+https://developers.google.com/open-source/licenses/bsd
+*/
+
+#ifndef REFTABLE_ERROR_H
+#define REFTABLE_ERROR_H
+
+/*
+ * Errors in reftable calls are signaled with negative integer return values. 0
+ * means success.
+ */
+enum reftable_error {
+	/* Unexpected file system behavior */
+	REFTABLE_IO_ERROR = -2,
+
+	/* Format inconsistency on reading data */
+	REFTABLE_FORMAT_ERROR = -3,
+
+	/* File does not exist. Returned from block_source_from_file(), because
+	 * it needs special handling in stack.
+	 */
+	REFTABLE_NOT_EXIST_ERROR = -4,
+
+	/* Trying to write out-of-date data. */
+	REFTABLE_LOCK_ERROR = -5,
+
+	/* Misuse of the API:
+	 *  - on writing a record with NULL refname.
+	 *  - on writing a reftable_ref_record outside the table limits
+	 *  - on writing a ref or log record before the stack's
+	 * next_update_inde*x
+	 *  - on writing a log record with multiline message with
+	 *  exact_log_message unset
+	 *  - on reading a reftable_ref_record from log iterator, or vice versa.
+	 *
+	 * When a call misuses the API, the internal state of the library is
+	 * kept unchanged.
+	 */
+	REFTABLE_API_ERROR = -6,
+
+	/* Decompression error */
+	REFTABLE_ZLIB_ERROR = -7,
+
+	/* Wrote a table without blocks. */
+	REFTABLE_EMPTY_TABLE_ERROR = -8,
+
+	/* Dir/file conflict. */
+	REFTABLE_NAME_CONFLICT = -9,
+
+	/* Invalid ref name. */
+	REFTABLE_REFNAME_ERROR = -10,
+};
+
+/* convert the numeric error code to a string. The string should not be
+ * deallocated. */
+const char *reftable_error_str(int err);
+
+#endif
-- 
gitgitgadget
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Han-Wen Nienhuys via GitGitGadget
Message 32 of 132 in “Support reftable ref backend for Git”
  1. 00/26 Support reftable ref backend for GitHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  2. 01/26 hash.h: provide constants for the hash IDsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  3. 02/26 init-db: set the_repository->hash_algo early onHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  4. 03/26 reftable: RFC: add LICENSEHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  5. 06/26 reftable: add blocksource, an abstraction for random access readsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  6. 04/26 reftable: add error related functionalityHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  7. 05/26 reftable: utility functionsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  8. 08/26 Provide zlib's uncompress2 from compat/zlib-compat.cHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  9. 07/26 reftable: (de)serialization for the polymorphic record type.Han-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  10. 10/26 reftable: a generic binary tree implementationHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  11. 13/26 reftable: read reftable filesHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  12. 15/26 reftable: add a heap-based priority queue for reftable recordsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  13. 09/26 reftable: reading/writing blocksHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  14. 12/26 reftable: generic interface to tablesHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  15. 14/26 reftable: reftable file level testsHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  16. 11/26 reftable: write reftable filesHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  17. 19/26 reftable: add dump utilityHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  18. 17/26 reftable: implement refname validationHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  19. 16/26 reftable: add merged table viewHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  20. 20/26 refs: RFC: Reftable support for git-coreHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  21. 24/26 t1401,t2011: parameterize HEAD.lock for REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  22. 23/26 t1301: document what needs to be done for reftableHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  23. 26/26 t7004: avoid direct filesystem accessHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  24. 25/26 t1404: annotate test cases with REFFILESHan-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  25. 21/26 git-prompt: prepare for reftable refs backendSZEDER Gábor via GitGitGadget, Jul 20, 2021
  26. 18/26 reftable: implement stack, a mutable database of reftable files.Han-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  27. 22/26 Add "test-tool dump-reftable" command.Han-Wen Nienhuys via GitGitGadget, Jul 20, 2021
  28. 00/25 Support reftable ref backend for GitHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  29. 01/25 hash.h: provide constants for the hash IDsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  30. 02/25 init-db: set the_repository->hash_algo early onHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  31. 03/25 reftable: RFC: add LICENSEHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  32. 04/25 reftable: add error related functionalityHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  33. 05/25 reftable: utility functionsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  34. 06/25 reftable: add blocksource, an abstraction for random access readsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  35. 08/25 Provide zlib's uncompress2 from compat/zlib-compat.cHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  36. 07/25 reftable: (de)serialization for the polymorphic record type.Han-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  37. Carlo Marcelo Arenas BelónAug 16, 2021
  38. Han-Wen NienhuysAug 17, 2021
  39. 09/25 reftable: reading/writing blocksHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  40. 10/25 reftable: a generic binary tree implementationHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  41. 11/25 reftable: write reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  42. 12/25 reftable: generic interface to tablesHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  43. 13/25 reftable: read reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  44. 14/25 reftable: reftable file level testsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  45. 15/25 reftable: add a heap-based priority queue for reftable recordsHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  46. 16/25 reftable: add merged table viewHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  47. 17/25 reftable: implement refname validationHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  48. 18/25 reftable: implement stack, a mutable database of reftable files.Han-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  49. 19/25 reftable: add dump utilityHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  50. 21/25 git-prompt: prepare for reftable refs backendSZEDER Gábor via GitGitGadget, Aug 16, 2021
  51. 20/25 refs: RFC: Reftable support for git-coreHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  52. 22/25 Add "test-tool dump-reftable" command.Han-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  53. 23/25 t1301: document what needs to be done for reftableHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  54. 24/25 t1401,t2011: parameterize HEAD.lock for REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  55. 25/25 t1404: annotate test cases with REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 16, 2021
  56. Junio C HamanoAug 16, 2021
  57. Han-Wen NienhuysAug 17, 2021
  58. 00/25 Support reftable ref backend for GitHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  59. 01/25 hash.h: provide constants for the hash IDsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  60. Ævar Arnfjörð BjarmasonAug 23, 2021
  61. 06/25 reftable: add blocksource, an abstraction for random access readsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  62. 08/25 Provide zlib's uncompress2 from compat/zlib-compat.cHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  63. Philip OakleyAug 18, 2021
  64. Han-Wen NienhuysAug 18, 2021
  65. Philip OakleyAug 18, 2021
  66. 09/25 reftable: reading/writing blocksHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  67. 05/25 reftable: utility functionsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  68. 03/25 reftable: RFC: add LICENSEHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  69. 04/25 reftable: add error related functionalityHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  70. 12/25 reftable: generic interface to tablesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  71. 07/25 reftable: (de)serialization for the polymorphic record type.Han-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  72. 11/25 reftable: write reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  73. 10/25 reftable: a generic binary tree implementationHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  74. 21/25 git-prompt: prepare for reftable refs backendSZEDER Gábor via GitGitGadget, Aug 17, 2021
  75. 20/25 refs: RFC: Reftable support for git-coreHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  76. Ævar Arnfjörð BjarmasonAug 23, 2021
  77. Han-Wen NienhuysAug 30, 2021
  78. Ævar Arnfjörð BjarmasonAug 30, 2021
  79. 19/25 reftable: add dump utilityHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  80. 15/25 reftable: add a heap-based priority queue for reftable recordsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  81. 13/25 reftable: read reftable filesHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  82. 25/25 t1404: annotate test cases with REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  83. 16/25 reftable: add merged table viewHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  84. 18/25 reftable: implement stack, a mutable database of reftable files.Han-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  85. 24/25 t1401,t2011: parameterize HEAD.lock for REFFILESHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  86. 22/25 Add "test-tool dump-reftable" command.Han-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  87. 17/25 reftable: implement refname validationHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  88. 23/25 t1301: document what needs to be done for reftableHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  89. 14/25 reftable: reftable file level testsHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  90. 02/25 init-db: set the_repository->hash_algo early onHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  91. Ævar Arnfjörð BjarmasonAug 23, 2021
  92. Ævar Arnfjörð BjarmasonAug 26, 2021
  93. 00/28 Support reftable ref backend for GitÆvar Arnfjörð Bjarmason, Aug 23, 2021
  94. 01/28 hash.h: provide constants for the hash IDsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  95. 02/28 init-db: set the_repository->hash_algo early onÆvar Arnfjörð Bjarmason, Aug 23, 2021
  96. 03/28 reftable: RFC: add LICENSEÆvar Arnfjörð Bjarmason, Aug 23, 2021
  97. 04/28 reftable: add error related functionalityÆvar Arnfjörð Bjarmason, Aug 23, 2021
  98. 05/28 reftable: utility functionsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  99. 06/28 reftable: add blocksource, an abstraction for random access readsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  100. 07/28 reftable: (de)serialization for the polymorphic record type.Ævar Arnfjörð Bjarmason, Aug 23, 2021
  101. 08/28 Provide zlib's uncompress2 from compat/zlib-compat.cÆvar Arnfjörð Bjarmason, Aug 23, 2021
  102. 09/28 reftable: reading/writing blocksÆvar Arnfjörð Bjarmason, Aug 23, 2021
  103. 10/28 reftable: a generic binary tree implementationÆvar Arnfjörð Bjarmason, Aug 23, 2021
  104. 12/28 reftable: generic interface to tablesÆvar Arnfjörð Bjarmason, Aug 23, 2021
  105. 13/28 reftable: read reftable filesÆvar Arnfjörð Bjarmason, Aug 23, 2021
  106. 14/28 reftable: reftable file level testsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  107. 15/28 reftable: add a heap-based priority queue for reftable recordsÆvar Arnfjörð Bjarmason, Aug 23, 2021
  108. 16/28 reftable: add merged table viewÆvar Arnfjörð Bjarmason, Aug 23, 2021
  109. 17/28 reftable: implement refname validationÆvar Arnfjörð Bjarmason, Aug 23, 2021
  110. 19/28 reftable: add dump utilityÆvar Arnfjörð Bjarmason, Aug 23, 2021
  111. 18/28 reftable: implement stack, a mutable database of reftable files.Ævar Arnfjörð Bjarmason, Aug 23, 2021
  112. Junio C HamanoAug 27, 2021
  113. reftable: fixup for broken __FUNCTION__ useÆvar Arnfjörð Bjarmason, Aug 27, 2021
  114. Carlo ArenasAug 27, 2021
  115. Han-Wen NienhuysAug 30, 2021
  116. 21/28 git-prompt: prepare for reftable refs backendÆvar Arnfjörð Bjarmason, Aug 23, 2021
  117. 20/28 refs: RFC: Reftable support for git-coreÆvar Arnfjörð Bjarmason, Aug 23, 2021
  118. 22/28 Add "test-tool dump-reftable" command.Ævar Arnfjörð Bjarmason, Aug 23, 2021
  119. 23/28 t1301: document what needs to be done for reftableÆvar Arnfjörð Bjarmason, Aug 23, 2021
  120. 26/28 reftable: fixup for new base topic 1/3Ævar Arnfjörð Bjarmason, Aug 23, 2021
  121. 25/28 t1404: annotate test cases with REFFILESÆvar Arnfjörð Bjarmason, Aug 23, 2021
  122. 24/28 t1401,t2011: parameterize HEAD.lock for REFFILESÆvar Arnfjörð Bjarmason, Aug 23, 2021
  123. 27/28 reftable: fixup for new base topic 2/3Ævar Arnfjörð Bjarmason, Aug 23, 2021
  124. Han-Wen NienhuysAug 30, 2021
  125. Ævar Arnfjörð BjarmasonAug 30, 2021
  126. Han-Wen NienhuysAug 30, 2021
  127. Ævar Arnfjörð BjarmasonAug 30, 2021
  128. 28/28 reftable: fixup for new base topic 3/3Ævar Arnfjörð Bjarmason, Aug 23, 2021
  129. 11/28 reftable: write reftable filesÆvar Arnfjörð Bjarmason, Aug 23, 2021
  130. Junio C HamanoAug 26, 2021
  131. Han-Wen NienhuysAug 26, 2021
  132. Junio C HamanoAug 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.