[PATCH v2 4/4] Documentation/Makefile: narrow wildcard rules to our known files
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Nov 29, 2022, 14:09 UTC
- Message-ID
- <patch-v2-4.4-f1bc3c16904-20221129T140159Z-avarab@gmail.com>
- In-Reply-To
- <cover-v2-0.4-00000000000-20221129T140159Z-avarab@gmail.com>
Instead of declaring that we'll generate e.g. any "%.1" from a corresponding "%.xml" let's narrow that list down to only our known manpage files, and likewise for %.xml.
We already generated e.g. "man1" on the basis of "$(DOC_MAN1)", we just weren't keeping track of what we were generating exactly in the these middle steps.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Documentation/Makefile | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile index 89929e3d60b..f84b54ac093 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -356,14 +356,14 @@ manpage-base-url.xsl: manpage-base-url.xsl.in $(QUIET_GEN)sed "s|@@MAN_BASE_URL@@|$(MAN_BASE_URL)|" $< > $@ $(DOC_MANN): manpage-base-url.xsl $(wildcard manpage*.xsl) -%.1 : %.xml - $(QUIET_XMLTO)$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< -%.5 : %.xml - $(QUIET_XMLTO)$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< -%.7 : %.xml - $(QUIET_XMLTO)$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $< - -%.xml : %.txt $(ASCIIDOC_DEPS) +define doc-mann-rule +$$(DOC_MAN$(1)) : %.$(1) : %.xml + $$(QUIET_XMLTO)$$(XMLTO) -m $$(MANPAGE_XSL) $$(XMLTO_EXTRA) man $$< + +endef +$(eval $(foreach n,1 5 7,$(call doc-mann-rule,$(n)))) + +$(MAN_XML): %.xml : %.txt $(ASCIIDOC_DEPS) $(QUIET_ASCIIDOC)$(TXT_TO_XML) -d manpage -o $@ $< user-manual.xml: user-manual.txt user-manual.conf asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS
-- 2.39.0.rc0.993.g0c499e58e3b