Re: [PATCH 1/1] Avoid multiple patterns when recipes generate one file
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Nov 28, 2022, 18:57 UTC
- Message-ID
- <221128.86k03ekis2.gmgdl@evledraar.gmail.com>
- In-Reply-To
- <43914959458ef34a0f29271afa9c9d981c2b3553.camel@gnu.org>
On Mon, Nov 28 2022, Paul Smith wrote:
Show 16 quoted lines
> On Mon, 2022-11-28 at 14:08 +0100, Ævar Arnfjörð Bjarmason wrote: >> Whether we use eval/define or not (I just tried to avoid the >> repetition) I think referring to $(DOC_MAN[157]) here probably makes >> more sense if we're poking at these rules. >> >> I.e. in this case the rest of the Makefile is carrying forward what >> manpages we're generating exactly, so rather than a wildcard %.1 to >> %.xml we can narrow it down to just the %.1 files we're going to b >> generating (but maybe that's best left for later...): > > I have no opinion on which is better :). > > I'm not sure what the above comment is asking for though: are you going > to take over pushing this change? Or do you want me to reroll the > commit with these changes instead? Or are we waiting for more > opinions?
Just a suggestion in case you thought it helped, but I think we can just go for your version.