git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/1] Makefiles: GNU make 4.4 fixes

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Nov 30, 2022, 08:23 UTC
Message-ID
<cover-v3-0.1-00000000000-20221130T081835Z-avarab@gmail.com>
In-Reply-To
<cover-v2-0.4-00000000000-20221129T140159Z-avarab@gmail.com>

A now much-smaller re-roll of a potential for-v2.39.0 fix for GNU make 4.4 compatibility.

Junio: Sorry about the overlapping submission, at the time I didn't
see Paul's in the "What's Cooking", and thought it hadn't been picked
up at all (maybe I just forgot to look at the actual branches).

This v3 is just the "MAKEFLAGS" patch. I agree with your [2] that we might want to leave this post-release, i.e. it'll just be (a lot) more verbose, but does it break anything? Probably not.

On the other hand the fix here is trivial, and literally just the exact solution to this compatibility problem suggested by GNU make's "NEWS" file, and nothing else. So merging this before the release should be low-risk...

1. https://lore.kernel.org/git/cover-v2-0.4-00000000000-20221129T140159Z-avarab@gmail.com/
2. https://lore.kernel.org/git/xmqqk03dyskc.fsf@gitster.g/
Ævar Arnfjörð Bjarmason (1):
  Makefiles: change search through $(MAKEFLAGS) for GNU make 4.4
 git-gui/Makefile | 2 +-
 shared.mak       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Range-diff against v2: 1: 42b4f241c97 < -: ----------- Documentation/Makefile: de-duplicate *.[157] dependency list 2: e232f308e40 < -: ----------- Documentation/Makefile: avoid multiple patterns when generating one file 3: 6db7dd74e52 = 1: 432518b2dd7 Makefiles: change search through $(MAKEFLAGS) for GNU make 4.4 4: f1bc3c16904 < -: ----------- Documentation/Makefile: narrow wildcard rules to our known files

-- 
2.39.0.rc0.1028.gb88f24da998
Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 17 of 23 in “Avoid multiple patterns when recipes generate one file”
  1. 0/1 Avoid multiple patterns when recipes generate one filePaul Smith, Nov 27, 2022
  2. 1/1 Avoid multiple patterns when recipes generate one filePaul Smith, Nov 27, 2022
  3. Ævar Arnfjörð BjarmasonNov 28, 2022
  4. Paul SmithNov 28, 2022
  5. Ævar Arnfjörð BjarmasonNov 28, 2022
  6. 0/4 Makefiles: GNU make 4.4 fixesÆvar Arnfjörð Bjarmason, Nov 29, 2022
  7. 3/4 Makefiles: change search through $(MAKEFLAGS) for GNU make 4.4Ævar Arnfjörð Bjarmason, Nov 29, 2022
  8. Junio C HamanoNov 30, 2022
  9. Paul SmithNov 30, 2022
  10. Ævar Arnfjörð BjarmasonDec 1, 2022
  11. 1/4 Documentation/Makefile: de-duplicate *.[157] dependency listÆvar Arnfjörð Bjarmason, Nov 29, 2022
  12. Junio C HamanoNov 30, 2022
  13. 2/4 Documentation/Makefile: avoid multiple patterns when generating one fileÆvar Arnfjörð Bjarmason, Nov 29, 2022
  14. Junio C HamanoNov 30, 2022
  15. 4/4 Documentation/Makefile: narrow wildcard rules to our known filesÆvar Arnfjörð Bjarmason, Nov 29, 2022
  16. Junio C HamanoNov 30, 2022
  17. 0/1 Makefiles: GNU make 4.4 fixesÆvar Arnfjörð Bjarmason, Nov 30, 2022
  18. 1/1 Makefiles: change search through $(MAKEFLAGS) for GNU make 4.4Ævar Arnfjörð Bjarmason, Nov 30, 2022
  19. Paul SmithNov 30, 2022
  20. Junio C HamanoNov 30, 2022
  21. Johannes SchindelinDec 6, 2022
  22. Ævar Arnfjörð BjarmasonDec 6, 2022
  23. Junio C HamanoDec 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.