git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t"

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jan 11, 2022, 16:40 UTC
Message-ID
<patch-3.3-93112305523-20220111T163908Z-avarab@gmail.com>
In-Reply-To
<cover-0.3-00000000000-20220111T163908Z-avarab@gmail.com>

Change code added in 1ae2b8cda84 (reftable: add merged table view, 2021-10-07) to consistently use the "uint64_t" type. These "min" and "max" variables get passed in the body of this function to a function whose prototype is:

    [...] reftable_writer_set_limits([...], uint64_t min, uint64_t max

This avoids the following warning on SunCC 12.5 on gcc211.fsffrance.org:

    "reftable/merged_test.c", line 27: warning: initializer does not fit or is out of range: 0xffffffff
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 reftable/merged_test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/reftable/merged_test.c b/reftable/merged_test.c
index 24461e8a802..b87ff495dfd 100644
--- a/reftable/merged_test.c
+++ b/reftable/merged_test.c
@@ -24,8 +24,8 @@ license that can be found in the LICENSE file or at
 static void write_test_table(struct strbuf *buf,
 			     struct reftable_ref_record refs[], int n)
 {
-	int min = 0xffffffff;
-	int max = 0;
+	uint64_t min = 0xffffffff;
+	uint64_t max = 0;
 	int i = 0;
 	int err;
 
-- 
2.35.0.rc0.844.gb5945183dcf
Previous: Junio C HamanoNext: Taylor Blau
Message 9 of 32 in “Fix SunCC compiler complaints new in v2.35.0-rc0”
  1. 0/3 Fix SunCC compiler complaints new in v2.35.0-rc0Ævar Arnfjörð Bjarmason, Jan 11, 2022
  2. 1/3 test-tool genzeros: initialize "zeros" to avoid SunCC warningÆvar Arnfjörð Bjarmason, Jan 11, 2022
  3. Taylor BlauJan 11, 2022
  4. Johannes SchindelinJan 12, 2022
  5. Taylor BlauJan 12, 2022
  6. Ævar Arnfjörð BjarmasonJan 13, 2022
  7. Johannes SchindelinJan 13, 2022
  8. Junio C HamanoJan 13, 2022
  9. 3/3 reftable tests: avoid "int" overflow, use "uint64_t"Ævar Arnfjörð Bjarmason, Jan 11, 2022
  10. Taylor BlauJan 11, 2022
  11. Han-Wen NienhuysJan 11, 2022
  12. Taylor BlauJan 11, 2022
  13. Johannes SixtJan 11, 2022
  14. Taylor BlauJan 11, 2022
  15. Johannes SixtJan 11, 2022
  16. Taylor BlauJan 11, 2022
  17. Johannes SchindelinJan 12, 2022
  18. Junio C HamanoJan 12, 2022
  19. Taylor BlauJan 12, 2022
  20. Ævar Arnfjörð BjarmasonJan 13, 2022
  21. Junio C HamanoJan 13, 2022
  22. 2/3 reftable: remove unreachable "return" statementsÆvar Arnfjörð Bjarmason, Jan 11, 2022
  23. Taylor BlauJan 11, 2022
  24. Ævar Arnfjörð BjarmasonJan 12, 2022
  25. Taylor BlauJan 12, 2022
  26. Ævar Arnfjörð BjarmasonJan 13, 2022
  27. Johannes SchindelinJan 13, 2022
  28. Johannes SixtJan 13, 2022
  29. Junio C HamanoJan 13, 2022
  30. Han-Wen NienhuysJan 11, 2022
  31. René ScharfeJan 11, 2022
  32. Emily ShafferJan 12, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.