git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t"

From
Taylor Blau <me@ttaylorr.com>
Date
Jan 11, 2022, 20:18 UTC
Message-ID
<Yd3mCVLyxkVTNcS9@nand.local>
In-Reply-To
<45baffd7-c9f3-cc52-47b4-ea0fee0182a8@kdbg.org>
On Tue, Jan 11, 2022 at 09:08:46PM +0100, Johannes Sixt wrote:
Show 16 quoted lines
> Am 11.01.22 um 20:41 schrieb Taylor Blau:
> > On Tue, Jan 11, 2022 at 08:31:47PM +0100, Han-Wen Nienhuys wrote:
> >> On Tue, Jan 11, 2022 at 8:28 PM Taylor Blau <me@ttaylorr.com> wrote:
> >>> In any case, you're only setting the lower half of `min` high. Maybe:
> >>>
> >>>     uint64_t min = ~0ul;
> >>
> >> yeah, that works.
> >
> > I'm pretty sure this is OK on 32-bit systems, too, but confirmation from
> > somebody more confident than I in this area would be welcome :).
>
> It does not work on Windows: unsigned long is 32 bits wide. You have to
> make it
>
>    uint64_t min = ~(uint64_t)0;
Perfect; this is exactly what I was looking for. Thanks!
Taylor
Previous: Johannes SixtNext: Johannes Sixt
Message 14 of 32 in “Fix SunCC compiler complaints new in v2.35.0-rc0”
  1. 0/3 Fix SunCC compiler complaints new in v2.35.0-rc0Ævar Arnfjörð Bjarmason, Jan 11, 2022
  2. 1/3 test-tool genzeros: initialize "zeros" to avoid SunCC warningÆvar Arnfjörð Bjarmason, Jan 11, 2022
  3. Taylor BlauJan 11, 2022
  4. Johannes SchindelinJan 12, 2022
  5. Taylor BlauJan 12, 2022
  6. Ævar Arnfjörð BjarmasonJan 13, 2022
  7. Johannes SchindelinJan 13, 2022
  8. Junio C HamanoJan 13, 2022
  9. 3/3 reftable tests: avoid "int" overflow, use "uint64_t"Ævar Arnfjörð Bjarmason, Jan 11, 2022
  10. Taylor BlauJan 11, 2022
  11. Han-Wen NienhuysJan 11, 2022
  12. Taylor BlauJan 11, 2022
  13. Johannes SixtJan 11, 2022
  14. Taylor BlauJan 11, 2022
  15. Johannes SixtJan 11, 2022
  16. Taylor BlauJan 11, 2022
  17. Johannes SchindelinJan 12, 2022
  18. Junio C HamanoJan 12, 2022
  19. Taylor BlauJan 12, 2022
  20. Ævar Arnfjörð BjarmasonJan 13, 2022
  21. Junio C HamanoJan 13, 2022
  22. 2/3 reftable: remove unreachable "return" statementsÆvar Arnfjörð Bjarmason, Jan 11, 2022
  23. Taylor BlauJan 11, 2022
  24. Ævar Arnfjörð BjarmasonJan 12, 2022
  25. Taylor BlauJan 12, 2022
  26. Ævar Arnfjörð BjarmasonJan 13, 2022
  27. Johannes SchindelinJan 13, 2022
  28. Johannes SixtJan 13, 2022
  29. Junio C HamanoJan 13, 2022
  30. Han-Wen NienhuysJan 11, 2022
  31. René ScharfeJan 11, 2022
  32. Emily ShafferJan 12, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.