Re: [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t"

From: Johannes Sixt <j6t@kdbg.org>
Date: Jan 11, 2022, 20:08 UTC
Message-ID: <45baffd7-c9f3-cc52-47b4-ea0fee0182a8@kdbg.org>
In-Reply-To: <Yd3dao5Qh5yl/cBs@nand.local>

Am 11.01.22 um 20:41 schrieb Taylor Blau:

Show 10 quoted lines

> On Tue, Jan 11, 2022 at 08:31:47PM +0100, Han-Wen Nienhuys wrote:
>> On Tue, Jan 11, 2022 at 8:28 PM Taylor Blau <me@ttaylorr.com> wrote:
>>> In any case, you're only setting the lower half of `min` high. Maybe:
>>>
>>>     uint64_t min = ~0ul;
>>
>> yeah, that works.
> 
> I'm pretty sure this is OK on 32-bit systems, too, but confirmation from
> somebody more confident than I in this area would be welcome :).

It does not work on Windows: unsigned long is 32 bits wide. You have to make it

   uint64_t min = ~(uint64_t)0;

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.