[PATCH v5 04/13] send-email: refactor sendemail.smtpencryption config parsing
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 28, 2021, 09:23 UTC
- Message-ID
- <patch-04.13-961ca4c2b2a-20210528T092228Z-avarab@gmail.com>
- In-Reply-To
- <cover-00.13-00000000000-20210528T092228Z-avarab@gmail.com>
With the removal of the support for sendemail.smtpssl in the preceding commit the parsing of sendemail.smtpencryption is no longer special, and can by moved to %config_settings.
This gets us rid of an unconditional call to Git::config(), which as we'll see in subsequent commits matters for startup performance.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- git-send-email.perl | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 9a1a4898e36..e2fe112aa50 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -287,6 +287,7 @@ sub do_edit { ); my %config_settings = ( + "smtpencryption" => \$smtp_encryption, "smtpserver" => \$smtp_server, "smtpserverport" => \$smtp_server_port, "smtpserveroption" => \@smtp_server_options, @@ -387,14 +388,6 @@ sub read_config { $$target = $v; } } - - if (!defined $smtp_encryption) { - my $setting = "$prefix.smtpencryption"; - my $enc = Git::config(@repo, $setting); - return unless defined $enc; - return if $configured->{$setting}++; - $smtp_encryption = $enc; - } } # sendemail.identity yields to --identity. We must parse this
-- 2.32.0.rc1.458.gd885d4f985c