Re: [PATCH v5 02/13] send-email tests: test for boolean variables without a value
- From
Jeff King <peff@peff.net>
- Date
- Jul 10, 2021, 23:23 UTC
- Message-ID
- <YOor1ztKLGvfk68i@coredump.intra.peff.net>
- In-Reply-To
- <patch-02.13-16277bd1082-20210528T092228Z-avarab@gmail.com>
On Fri, May 28, 2021 at 11:23:41AM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 11 quoted lines
> +test_expect_success $PREREQ '--[no-]xmailer with sendemail.xmailer' ' > + test_when_finished "test_unconfig sendemail.xmailer" && > + cat >>.git/config <<-\EOF && > + [sendemail] > + xmailer > + EOF > + test_config sendemail.xmailer true && > + do_xmailer_test 1 "" && > + do_xmailer_test 0 "--no-xmailer" && > + do_xmailer_test 1 "--xmailer" > +'
Is this test_config call in the middle of the snippet meant to be there? It seems like it would wreck the test, since it will rewrite the file to "xmailer = true". I'm guessing it's just leftover cruft from adapting the earlier xmailer=true test?
(I wasn't looking carefully again at this series, but just happened to be resolving a local conflict involving this hunk and noticed it).
-Peff