Re: [PATCH v4 00/13] send-email: various optimizations to speed up by >2x

From: Jeff King <peff@peff.net>
Date: May 27, 2021, 16:00 UTC
Message-ID: <YK/CEMd52k+cK0dz@coredump.intra.peff.net>
In-Reply-To: <cover-00.13-00000000000-20210524T074932Z-avarab@gmail.com>

On Mon, May 24, 2021 at 09:52:49AM +0200, Ævar Arnfjörð Bjarmason wrote:

> This v4 fixes an issue in v3 where 12/13 had a "diff --git" as part of
> the commit message (mistake during rebase/squash), which confused "git
> am" in trying to apply a diff twice. See <xmqqwnrplyns.fsf@gitster.g>.

I raised a probably-not-a-problem question in patch 12. Assuming it's indeed not-a-problem, this all looks good to me.

Thanks for addressing my concerns about Git.pm stability.

-Peff

PS I hit some mild conflicts applying this on top of master because
   7cbc0455cc (send-email: move "hooks_path" invocation to
   git-send-email.perl, 2021-05-26) graduated in the meantime. I expect
   Junio prefers it as you have it here, since he tends to use the
   original base from previous rounds, but just a hint to any other
   reviewers.