Re: [PATCH v2] userdiff: better method/property matching for C#

From: Linus Arver <linusa@google.com>
Date: Mar 16, 2024, 18:14 UTC
Message-ID: <owlyy1ai2gdk.fsf@fine.c.googlers.com>
In-Reply-To: <pull.1682.v2.git.git.1709756493673.gitgitgadget@gmail.com>

"Steven Jeuris via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 11 quoted lines

> From: Steven Jeuris <steven.jeuris@3shape.com>
>
> - Support multi-line methods by not requiring closing parenthesis.
> - Support multiple generics (comma was missing before).
> - Add missing `foreach`, `lock` and  `fixed` keywords to skip over.
> - Remove `instanceof` keyword, which isn't C#.
> - Also detect non-method keywords not positioned at the start of a line.
> - Added tests; none existed before.
>
> The overall strategy is to focus more on what isn't expected for
> method/property definitions, instead of what is, but is fully optional.

It would make it easier to review if you broke this patch up into smaller chunks. For example, you could do it like this:

  (1) add tests to capture existing behavior
  (2a) change method/property matching behavior, one thing at a time
  (2b) adjust or add tests along the way, to account for the change in (2a)
  (3) repeat step (2) as needed for each of the bullet points you've
      outlined already

Not being familiar with this area, I don't know if (2b) is easily doable. But if it is, I think the overall effort of breaking this patch down would be worthwhile.

Of course, nothing stops other reviewers (who are more familiar with this area) from chiming in and LGTM'ing this patch as is.

Thanks.