git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5] userdiff: better method/property matching for C#

From
Johannes Sixt <j6t@kdbg.org>
Date
Apr 5, 2024, 22:02 UTC
Message-ID
<c2154457-3f2f-496e-9b8b-c8ea7257027b@kdbg.org>
In-Reply-To
<pull.1682.v5.git.git.1712180564927.gitgitgadget@gmail.com>
Am 03.04.24 um 23:42 schrieb Steven Jeuris via GitGitGadget:
Show 13 quoted lines
> From: Steven Jeuris <steven.jeuris@3shape.com>
> 
> - Support multi-line methods by not requiring closing parenthesis.
> - Support multiple generics (comma was missing before).
> - Add missing `foreach`, `lock` and  `fixed` keywords to skip over.
> - Remove `instanceof` keyword, which isn't C#.
> - Also detect non-method keywords not positioned at the start of a line.
> - Added tests; none existed before.
> 
> The overall strategy is to focus more on what isn't expected for
> method/property definitions, instead of what is, but is fully optional.
> 
> Signed-off-by: Steven Jeuris <steven.jeuris@gmail.com>
Show 8 quoted lines
>     Change since v4:
>     
>      * Better matching of at least two "words".
>      * Better handling of generics by restricting commas within < ... >.
>      * Allow any spaces around commas in generics.
>      * Because of stricter use of comma, Johannes' identified failing cases
>        now pass.
>      * Updated tests to cover all of the above.

The proposed patterns look reasonable and are an improvement over the existing patterns, so I think we can move this patch forward.

Thank you, -- Hannes

Previous: Steven Jeuris via GitGitGadgetNext: Junio C Hamano
Message 13 of 14 in “userdiff: better method/property matching for C#”
  1. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Feb 25, 2024
  2. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Mar 6, 2024
  3. Junio C HamanoMar 7, 2024
  4. Linus ArverMar 16, 2024
  5. Junio C HamanoMar 26, 2024
  6. Jeff KingMar 27, 2024
  7. Johannes SixtMar 27, 2024
  8. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Mar 28, 2024
  9. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Mar 28, 2024
  10. Junio C HamanoMar 28, 2024
  11. Johannes SixtMar 30, 2024
  12. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Apr 3, 2024
  13. Johannes SixtApr 5, 2024
  14. Junio C HamanoApr 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.