git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] userdiff: better method/property matching for C#

From
Jeff King <peff@peff.net>
Date
Mar 27, 2024, 08:40 UTC
Message-ID
<20240327084005.GE830163@coredump.intra.peff.net>
In-Reply-To
<xmqqfrwc8yhq.fsf@gitster.g>
On Tue, Mar 26, 2024 at 02:38:41PM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> >     userdiff: better method/property matching for C#
> >     
> >     Change since v1: I removed "from" from the list of keywords to skip.
> >     First, I considered adding "await", but I discovered both "await" and
> >     "from" are "contextual keywords", which unlike the other keywords
> >     currently listed, aren't reserved, and can thus cause false negatives.
> >     I.e., it is valid to have a method named "await" or "from". In edge
> >     cases, this may lead to false positives, but a different exclusion rule
> >     will need to be added to handle these.
> 
> It seems that this has seen no reviews.  I somehow find it doubtful
> that Ævar or Peff would be writing too much C# to be familiar with
> the language to judge the quality of the patch, but can somebody
> with C# background (I hear that its most common use is for
> developing Windows applications etc. there) chip in?

Yeah, sorry, I have never written a line of C# in my life, so I have been dutifully ignoring this series. :)

-Peff
Previous: Junio C HamanoNext: Johannes Sixt
Message 6 of 14 in “userdiff: better method/property matching for C#”
  1. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Feb 25, 2024
  2. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Mar 6, 2024
  3. Junio C HamanoMar 7, 2024
  4. Linus ArverMar 16, 2024
  5. Junio C HamanoMar 26, 2024
  6. Jeff KingMar 27, 2024
  7. Johannes SixtMar 27, 2024
  8. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Mar 28, 2024
  9. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Mar 28, 2024
  10. Junio C HamanoMar 28, 2024
  11. Johannes SixtMar 30, 2024
  12. userdiff: better method/property matching for C#Steven Jeuris via GitGitGadget, Apr 3, 2024
  13. Johannes SixtApr 5, 2024
  14. Junio C HamanoApr 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.