Re: [PATCH v2 0/3] refs: sync loose refs to disk before committing them

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 10, 2021, 14:44 UTC
Message-ID: <nycvar.QRO.7.76.6.2111101534370.21127@tvgsbejvaqbjf.bet>
In-Reply-To: <cover.1636544377.git.ps@pks.im>

Hi Patrick,

On Wed, 10 Nov 2021, Patrick Steinhardt wrote:

> This series is implements the same batching as Neeraj's series [1]. It
> introduces a new config switch "core.fsyncRefFiles" with the same three
> toggles "on", "off" and "batch". Given that it reuses funcitonality
> provided by the batched object flushing this series is based on "next".

Excellent, I am glad that my idea was helpful.

I read through the patches and found them easy to follow. Even 3/3, which was a bit complex because of the need to support both transacted ref updates as well as atomic renames/copies, is clear and well-written.

FWIW you could base your patches directly on `ns/batched-fsync`, I would think.

Thank you, Dscho