Re: [PATCH v2 5/7] rebase: drop support for `--preserve-merges`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 2, 2021, 13:54 UTC
Message-ID: <nycvar.QRO.7.76.6.2109021553510.55@tvgsbejvaqbjf.bet>
In-Reply-To: <8735qowknu.fsf@evledraar.gmail.com>

Hi Ævar,

On Wed, 1 Sep 2021, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

>
> On Wed, Sep 01 2021, Johannes Schindelin via GitGitGadget wrote:
>
> > -	struct strbuf script_snippet = STRBUF_INIT, buf = STRBUF_INIT;
> > +	struct strbuf script_snippet = STRBUF_INIT;
>
> You end up removing all uses of script_snippet except the
> strbuf_release() for it, so this & that can be removed too.

Valid point, I missed it because compiling with `DEVELOPER=1` did not complain (because `strbuf_release()` "uses" the variable).

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.