From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 02 Sep 2021 13:54:30 GMT
Subject: Re: [PATCH v2 5/7] rebase: drop support for `--preserve-merges`
Message-ID: <nycvar.QRO.7.76.6.2109021553510.55@tvgsbejvaqbjf.bet>
In-Reply-To: <8735qowknu.fsf@evledraar.gmail.com>

Hi Ævar,

On Wed, 1 Sep 2021, Ævar Arnfjörð Bjarmason wrote:

>
> On Wed, Sep 01 2021, Johannes Schindelin via GitGitGadget wrote:
>
> > -	struct strbuf script_snippet = STRBUF_INIT, buf = STRBUF_INIT;
> > +	struct strbuf script_snippet = STRBUF_INIT;
>
> You end up removing all uses of script_snippet except the
> strbuf_release() for it, so this & that can be removed too.

Valid point, I missed it because compiling with `DEVELOPER=1` did not
complain (because `strbuf_release()` "uses" the variable).

Ciao,
Dscho