Re: [PATCH v2 5/7] rebase: drop support for `--preserve-merges`

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 2, 2021, 14:56 UTC
Message-ID: <87czpr9fwz.fsf@evledraar.gmail.com>
In-Reply-To: <87lf4f9gre.fsf@evledraar.gmail.com>

On Thu, Sep 02 2021, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> On Wed, Sep 01 2021, Johannes Schindelin via GitGitGadget wrote:
>
>>  git-rebase--preserve-merges.sh | 1057 --------------------------------
>
> You could, but certainly don't have to, squash in the below. I.e. this
> is the last user of eval_ngettext!

Also get_author_ident_from_commit() in git-sh-setup.sh and Documentation/git-sh-setup.txt can be removed, git-rebase--preserve-merges.sh is the last user of it.

I looked over the other git-sh-setup functions, it seems that's the only one that could be removed along with git-rebase--preserve-merges.sh.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.