Re: [PATCH v1 0/4] advice: remove usage of `advice_*` global variables
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 2, 2021, 22:15 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2108030009330.55@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20210731022504.1912702-1-mathstuf@gmail.com>
Hi Ben,
On Fri, 30 Jul 2021, Ben Boeckel wrote:
> When looking at global variable usage for my `branch.default*` settings, > I found the `advice_` variables which were simple enough to resolve.
Even better, it concludes the journey started in c4a09cc9ccb (Merge branch 'hw/advise-ng', 2020-03-25).
I reviewed the entire series and left a few comments I believe to be constructive.
Since patch 2/4 resolves a problem introduced by merging divergent changes (one adding `advice_settings`, the other adding two entries to `advice_config`), an obvious concern with this patch series is: How can we guarantee that we're not introducing a similar problem when removing `advice_config`? A future branch could easily add entries to that array, and a merge of this here topic could potentially forget to add those entries to `advice_settings`.
However, such a future merge would always cause merge (add/remove) conflicts in the `advice_config` array, i.e. it will be much easier to notice such a divergence, and hence it will be much more likely that the `advice_setting` array will be adjusted accordingly in such a hypothetical merge.
Ciao, Dscho