Re: [PATCH v1 4/4] advice: remove static global variables for advice tracking

From: Ben Boeckel <mathstuf@gmail.com>
Date: Aug 3, 2021, 00:44 UTC
Message-ID: <YQiRVhofZktlBF22@erythro.dev.benboeckel.internal>
In-Reply-To: <nycvar.QRO.7.76.6.2108030007060.55@tvgsbejvaqbjf.bet>

On Tue, Aug 03, 2021 at 00:09:25 +0200, Johannes Schindelin wrote:

Show 9 quoted lines

> On Fri, 30 Jul 2021, Ben Boeckel wrote:
> > All of the preferences are now tracked as part of the `advice_setting`
> > array and all consumers of the global variables have been removed, so
> > the parallel tracking through `advice_config` is no longer necessary.
> 
> Maybe add "This concludes the move from the old advice API to the new one
> introduced via c4a09cc9ccb (Merge branch 'hw/advise-ng', 2020-03-25)"?
> 
> At least this reader would have found that helpful.

Agreed.

> And as I mentioned in the review of patch 3/4, the removal of the
> explicit assignment to the `advice_*` global variables should be moved
> here.

I addressed this in the 3/4 thread.

Thanks,

--Ben