Re: [RFC PATCH v3 2/4] advice: remove read uses of most global `advice_` variables

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 6, 2021, 19:30 UTC
Message-ID: <CAPig+cQiSzXG4NBX+X+1XxjQ9AN4B6us3m-gj-11zctCcm0NqQ@mail.gmail.com>
In-Reply-To: <RFC-patch-v3-2.4-eefcafcf8f-20210806T191231Z-avarab@gmail.com>

/On Fri, Aug 6, 2021 at 3:13 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 8 quoted lines

> In c4a09cc9ccb (Merge branch 'hw/advise-ng', 2020-03-25), a new API for
> accessing advice variables was introduced and deprecated `advice_config`
> in favor of a new array, `advice_setting`.
>
> This patch ports all but two uses which read the status of the global
> `advice_` variables over to the new `advice_enabled` API. We'll deal
> with advice_add_embedded_repo and advice_graft_file_deprecated
> seperately.

s/seperately/separately/

> Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>