Re: [PATCH 0/3] Make CMake work out of the box

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 10, 2021, 09:43 UTC
Message-ID: <nycvar.QRO.7.76.6.2106101140590.57@tvgsbejvaqbjf.bet>
In-Reply-To: <6a9150ca-5c1a-1874-5f8b-35187f197d47@gmail.com>

Hi,

On Sat, 5 Jun 2021, Bagas Sanjaya wrote:

Show 18 quoted lines

> On 05/06/21 00.43, Matthew Rogers via GitGitGadget wrote:
> > This pull request comes from our discussion here[1], and I think these
> > patches provide a good compromise around the concerns discussed there
> >
> > 1:
> > https://lore.kernel.org/git/CAOjrSZusMSvs7AS-ZDsV8aQUgsF2ZA754vSDjgFKMRgi_oZAWw@mail.gmail.com/
> >
> > CCing the people involved in the original discussion.
>
> This focused on improving CMake support, especially on Visual Studio, right?
>
> Then so we have three ways to build Git:
> 1. plain Makefile
> 2. ./configure (really just wrapper on top of Makefile)
> 3. generate build file with CMake
>
> If we want to support all of them, it may makes sense to have CI jobs that
> perform build with each options above.

We already exercise the plain Makefile plenty, and the CMake-based build using Windows (in the `vs-build` job in `.github/workflows/main.yml`).

I do not see that it is worth spending many electrons exercising the `./configure` way, seeing as the preferred way to build Git is by using the `Makefile` directly.

And our CMake configuration only really works on Windows, the attempts to get it to work on Linux were met with less enthusiasm, seeing as the `Makefile` approach is the recommended (and supported) one.

tl;dr I don't think we need to augment our CI jobs as suggested.

Ciao, Dscho