Re: [PATCH 1/3] cmake: add knob to disable vcpkg
- From
Matt Rogers <mattr94@gmail.com>
- Date
- Jun 5, 2021, 22:30 UTC
- Message-ID
- <CAOjrSZv9h09y-=KVz8UGZaB0r5MHRqFZJjp0VDFX6fnohoFx9Q@mail.gmail.com>
- In-Reply-To
- <CAKiG+9UT+B-kFiY7sA8ZedB31xYARbFgSFwQRzktww_S2B_tfA@mail.gmail.com>
On Fri, Jun 4, 2021 at 4:55 PM Sibi Siddharthan <sibisiddharthan.github@gmail.com> wrote:
Show 17 quoted lines
> > On Fri, Jun 4, 2021 at 11:13 PM Matthew Rogers via GitGitGadget > <gitgitgadget@gmail.com> wrote: > > > -if(WIN32) > > + > > +if (WIN32 AND NOT NO_VCPKG) > > + set(USING_VCPKG TRUE) > > +else() > > + set(USING_VCPKG FALSE) > > +endif() > > I think it would be better if we could have an option for this knob. > Maybe like this > > option(NO_VCPKG "Don't use vcpkg for obtaining dependencies. Only > applicable to Windows platforms" OFF)
Option would definitely be the better tool to use here, I just didn't think about it when originally writing it, so I'll send a reroll with that and the spelling corrections suggested by Eric Sunshine. I assume you'd prefer something with a final form more like:
option(USE_VCPKG "Whether or not to use vcpkg for obtaining dependencies. Only applicable to Windows platforms" ON)
Show 5 quoted lines
> > I would prefer to use `USE_VCPKG`. > > Thank You, > Sibi Siddharthan
-- Matthew Rogers