git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] cmake: add knob to disable vcpkg

From
Sibi Siddharthan <sibisiddharthan.github@gmail.com>
Date
Jun 4, 2021, 20:55 UTC
Message-ID
<CAKiG+9UT+B-kFiY7sA8ZedB31xYARbFgSFwQRzktww_S2B_tfA@mail.gmail.com>
In-Reply-To
<3170f78daa5fa89f04f61e24c9c64c93ea5b394f.1622828605.git.gitgitgadget@gmail.com>

On Fri, Jun 4, 2021 at 11:13 PM Matthew Rogers via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 7 quoted lines
> -if(WIN32)
> +
> +if (WIN32 AND NOT NO_VCPKG)
> +       set(USING_VCPKG TRUE)
> +else()
> +       set(USING_VCPKG FALSE)
> +endif()

I think it would be better if we could have an option for this knob. Maybe like this

option(NO_VCPKG "Don't use vcpkg for obtaining dependencies. Only applicable to Windows platforms" OFF)

I would prefer to use `USE_VCPKG`.

Thank You, Sibi Siddharthan

Previous: Matt RogersNext: Matt Rogers
Message 5 of 31 in “Make CMake work out of the box”
  1. 0/3 Make CMake work out of the boxMatthew Rogers via GitGitGadget, Jun 4, 2021
  2. 1/3 cmake: add knob to disable vcpkgMatthew Rogers via GitGitGadget, Jun 4, 2021
  3. Eric SunshineJun 4, 2021
  4. Matt RogersJun 4, 2021
  5. Sibi SiddharthanJun 4, 2021
  6. Matt RogersJun 5, 2021
  7. Sibi SiddharthanJun 6, 2021
  8. 3/3 cmake: add warning for ignored MSGFMT_EXEMatthew Rogers via GitGitGadget, Jun 4, 2021
  9. Eric SunshineJun 4, 2021
  10. 2/3 cmake: create compile_commands.json by defaultMatthew Rogers via GitGitGadget, Jun 4, 2021
  11. Eric SunshineJun 4, 2021
  12. Sibi SiddharthanJun 4, 2021
  13. Matt RogersJun 5, 2021
  14. Sibi SiddharthanJun 6, 2021
  15. Bagas SanjayaJun 5, 2021
  16. Matt RogersJun 5, 2021
  17. Johannes SchindelinJun 10, 2021
  18. Philip OakleyJun 18, 2021
  19. Johannes SchindelinJun 18, 2021
  20. Philip OakleyJun 18, 2021
  21. Johannes SchindelinJun 22, 2021
  22. 0/3 Make CMake work out of the boxMatthew Rogers via GitGitGadget, Jun 6, 2021
  23. 1/3 cmake: add knob to disable vcpkgMatthew Rogers via GitGitGadget, Jun 6, 2021
  24. 2/3 cmake: create compile_commands.json by defaultMatthew Rogers via GitGitGadget, Jun 6, 2021
  25. 3/3 cmake: add warning for ignored MSGFMT_EXEMatthew Rogers via GitGitGadget, Jun 6, 2021
  26. Junio C HamanoJun 7, 2021
  27. Johannes SchindelinJun 10, 2021
  28. Philip OakleyJun 18, 2021
  29. Philip OakleyJun 18, 2021
  30. Johannes SchindelinJun 10, 2021
  31. Junio C HamanoJun 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.