Re: [RFC/PATCH] tests: support testing with an arbitrary default branch (sort of)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 19, 2020, 09:32 UTC
Message-ID: <nycvar.QRO.7.76.6.2011191030170.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqsg963bg9.fsf@gitster.c.googlers.com>

Hi Junio & Ævar,

On Wed, 18 Nov 2020, Junio C Hamano wrote:

Show 8 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
> > P.S.: Shouldn't the pull patch in d18c950a69f be using the advice
> >      facility, not warning()?
>
> I think warning() is the right thing here, as it is self squelching.
> Setting pull.rebase (even to 'false') is sufficient---there is no
> need to set advise.setpullrebase to 'false' on top.

Right. The only reason to use `advise()` would be to allow users to squelch the warning by setting `advice.*`.

On the other hand, warnings are not colored, but advice messages are.

And now I realize that the same holds for `init.defaultBranch`: it is also self-squelching. And it also might benefit from the coloring to make it stand out a bit.

Thoughts?

Ciao, Dscho