Re: [PATCH 00/28] Use main as default branch name
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 18, 2020, 20:58 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2011182156560.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqpn4b6bru.fsf@gitster.c.googlers.com>
Hi Junio,
On Tue, 17 Nov 2020, Junio C Hamano wrote:
Show 25 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > case "$TEST_NUMBER" in > > 3404|4013|5310|5526|6300|7064|7817|9902) > > # Avoid conflicts with patch series that are cooking at the same > > # time > > # as the patch series changing the default of > > # `init.defaultBranch`. > > GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master > > export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > > ;; > > *) > > GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main > > export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > > ;; > > esac > > I actually am not a big fan of the centralized table of "these want > to run with main". My ideal would be to have an explicit assignment > of either master or main for tests that absolutely require the > default to be one of these names at the top of these script, and any > test scripts that do not care what the initial branch is called > (perhaps because they begin by switching to a branch whose name is > picked by them immediately after they start and use that name > throughout) won't have GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME in them.
I will make it so in v3.
It does make sense, too: the four patch series I sent out in the past hours address some issues that I would have otherwise missed in the transition (in particular, two test cases with `test_must_fail` in them would have continued to pass, but for the wrong reason, during the transition to `main`.
Ciao, Dscho