Re: [PATCH] cmake: ignore generated files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 23, 2020, 13:08 UTC
Message-ID: <nycvar.QRO.7.76.6.2009231502430.5061@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqr1qud9zl.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, 21 Sep 2020, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> What I am hearing here is that people with CMake & VS use "git clean
> >> -dfx" when they want to go back to the pristine state, unlike those
> >> who use "make distclean", and there is nothing to adjust for newly
> >> discovered crufts we are leaving on the filesystem.
> >
> > Yes, that is my understanding.
>
> I do not know if you have read other messages in the thread,

I did.

> but my current understanding of what we learned in this thread [*1*] is
> that those who use CMake, especially in a tree like ours that has its
> own Makefiles, (sh|w)ould create a throw-away directory and run build
> there, so even "git clean -dxf" is not part of their "clean" procedure.

Well, our CMake support does not extend to generating Makefiles: we specifically target only Windows withour CMake support, and since there is no need to help developers who already use the Git for Windows SDK or Cygwin, we really focus only on supporting Visual Studio.

In that respect, I think that all that talk about Makefiles isn't quite spot on.

In any case, `git clean -dfx` strikes me as a perfectly acceptable equivalent of `make clean` when no `make` is available, as is the case in Visual Studio's case.

Ciao, Dscho

> [Footnote]
>
> *1* https://lore.kernel.org/git/20200919004030.GB1837@danh.dev/
>