Re: [PATCH] cmake: ignore generated files

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Sep 18, 2020, 15:50 UTC
Message-ID: <20200918155015.GA1837@danh.dev>
In-Reply-To: <xmqqft7fnlxr.fsf@gitster.c.googlers.com>

On 2020-09-18 08:28:48-0700, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> Good to catch these cruft.
> >>
> >> Does the equivalent of "make distclean" need to be updated to clean
> >> them as well, or is it sufficient to ignore the build procedure and
> >> just rely on "git clean -f -x"?
> >
> > Since CMake in conjunction with Visual Studio completely side-steps
> > `make`, I think it would make most sense to ignore `make distclean` in
> > this context and go for `git clean -dfx` instead.
> 
> I think you misunderstood the question, overlooking the "equivalent"
> part.
> 
> I expected that when CMake & VS discards build artifacts, it would
> not make literal use of "make distclean".  After all, it does not
> use "make all" to build, either.

Actually, in CMake land, people usually do this instead:

	mkdir build
	cmake [-Ggenerator] ..
	<make/ninja/msbuild>

Then, when they want to run something equivalent with make distclean, they run:

	cd ..
	rm -rf build

instead.

The change that Dscho suggested was meant for those people that run CMake in same directory of source dir, which is mostly discouraged in CMake land.

In additional, CMake's default Generator in *nix is Unix Makefiles, which will clash with our Makefile, and totally unsupported.

I think the original CMake proposal didn't touch .gitignore because they run in a separated build-dir.

-- 
Danh