Re: [RFC PATCH] t: move metadata into TAP test description
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 15, 2020, 22:42 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2005160041380.55@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqq3681m7s4.fsf@gitster.c.googlers.com>
Hi,
On Fri, 15 May 2020, Junio C Hamano wrote:
Show 20 quoted lines
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes: > > > On Fri, May 15, 2020 at 09:50:38AM -0700, Junio C Hamano wrote: > >> > >> At this late stage in the cycle, would it be a safer change to > >> revert the whole thing, I wonder, rather than piling fixes on top of > >> fixes to the initial breakage? > >> > >> 303775a2 (t/test_lib: avoid naked bash arrays in file_lineno, 2020-05-07) > >> 662f9cf1 (tests: when run in Bash, annotate test failures with file name/line number, 2020-04-11) > > > > will also need: > > > > 676eb0c1ce (ci: add a problem matcher for GitHub Actions, 2020-04-11) > > Yeah, I think that is a good idea. I suspect that leaving it there > won't cause problems, though---it would be just nothing is found to > be clicked and that's the end of it, no? > > Will add a revert to the series anyway.
Yes, I'm fine with reverting this, as breaking TAP is a rather bad side effect.
Ciao, Dscho