Re: [RFC PATCH] t: move metadata into TAP test description

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: May 15, 2020, 15:45 UTC
Message-ID: <20200515154539.GB61200@Carlos-MBP>
In-Reply-To: <880ded78-21c6-9310-6c5e-422f6a63ad47@gmail.com>

On Fri, May 15, 2020 at 05:38:21PM +0200, Alban Gruin wrote:

Show 23 quoted lines

> 
> Thinking about it, I think it would make sense to put this kind of
> information in a diagnostic line, as we already do for the code of a
> failed test.
> 
> Instead of this:
> 
> > not ok 1 - plain(error:t/./t0001-init.sh:33)
> > #
> > #               false &&
> > #               git init plain &&
> > #               check_config plain/.git false unset
> > #
> 
> Something like this:
> 
> > not ok 1 - plain
> > # (error:t/./t0001-init.sh:33)
> > #
> > #               false &&
> > #               git init plain &&
> > #               check_config plain/.git false unset
> > #

indeed, and that is why I mentioned this as a workaround only.

to move to a format like the one you suggest, it might be better to do it by also moving to TAP13[1] (which allows all that metadata)

but of course that would also require us to do more changes to the integration with GitHub's problem matchers and probably a lot more changes I am not even aware of.

Carlo

[1] http://testanything.org/tap-version-13-specification.html