Re: [PATCH 3/5] ci: configure GitHub Actions for CI/PR
- From
Danh Doan <congdanhqx@gmail.com>
- Date
- Apr 4, 2020, 23:55 UTC
- Message-ID
- <20200404235528.GB1896@danh.dev>
- In-Reply-To
- <nycvar.QRO.7.76.6.2004041952050.46@tvgsbejvaqbjf.bet>
On 2020-04-04 19:59:37+0200, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 21 quoted lines
> > > + linux-clang: > > > + runs-on: ubuntu-latest > > > + steps: > > > + - uses: actions/checkout@v1 > > > + - name: install dependencies > > > + env: > > > + CC: clang > > > + run: | > > > + sudo apt-get update && > > > + sudo apt-get -y install git gcc make libssl-dev libcurl4-openssl-dev libexpat-dev tcl tk gettext git-email zlib1g-dev apache2-bin && > > > > Why install all these dependencies here, when the very next command is > > 'ci/install-dependencies.sh', whose purpose is to install the > > dependencies? > > I copy/pasted these from `azure-pipelines.yml`, and agree that they should > be handled via `ci/install-dependencies.sh` instead. > > Danh (is this the correct way to address you?), if you want to have a look > at that, go for it. Otherwise I'll try to find some time to do that > myself.
I've managed to fix this part in the v4 series (only send privately to Dscho, because I'm waiting for other conversations to settle).
-- Danh