git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: avoid running curl-config unnecessarily

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 5, 2020, 22:12 UTC
Message-ID
<nycvar.QRO.7.76.6.2004060012120.46@tvgsbejvaqbjf.bet>
In-Reply-To
<CAPig+cR_ViZ2GWSs=grT=5bzQq44w+AAbXFsZaM_-CVMCELXQw@mail.gmail.com>
Hi,
On Sat, 4 Apr 2020, Eric Sunshine wrote:
Show 7 quoted lines
> On Sat, Apr 4, 2020 at 10:58 AM Jeff King <peff@peff.net> wrote:
> > This is our first use of eval in the Makefile, but that goes back to GNU
> > make v3.80, which is from 2002. I think that should be OK.
>
> Upon reading this, I was worried that it might trip up Mac OS which
> has (often very) old versions of tools, but it's alright in this case,
> as Apple ships GNU 'make' 3.81 from 2006.

I share this concern. It may be more robust, after all, to squelch the `curl-config` warning specifically in the `Documentation` job of our CI/PR runs.

Ciao, Dscho

Previous: Eric SunshineNext: Johannes Schindelin
Message 10 of 13 in “use `curl-config --cflags`”
  1. 0/2 use `curl-config --cflags`Jeff King, Mar 26, 2020
  2. 1/2 Makefile: avoid running curl-config multiple timesJeff King, Mar 26, 2020
  3. 2/2 Makefile: use curl-config --cflagsJeff King, Mar 26, 2020
  4. Junio C HamanoMar 27, 2020
  5. Johannes SchindelinApr 4, 2020
  6. Makefile: avoid running curl-config unnecessarilyJeff King, Apr 4, 2020
  7. Eric SunshineApr 5, 2020
  8. Jeff KingApr 5, 2020
  9. Eric SunshineApr 5, 2020
  10. Johannes SchindelinApr 5, 2020
  11. Johannes SchindelinApr 5, 2020
  12. Junio C HamanoApr 15, 2020
  13. Jeff KingApr 15, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.