git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: avoid running curl-config unnecessarily

From
Jeff King <peff@peff.net>
Date
Apr 15, 2020, 21:57 UTC
Message-ID
<20200415215731.GA3595073@coredump.intra.peff.net>
In-Reply-To
<xmqqzhbc4e0s.fsf@gitster.c.googlers.com>
On Wed, Apr 15, 2020 at 02:47:47PM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Junio, you may want to hold off on moving jk/build-with-right-curl to
> > next until we resolve this one way or the other.
> >
> > -- >8 --
> > Subject: [PATCH] Makefile: avoid running curl-config unnecessarily
> 
> I think this has been accepted favourably after all?  I am inclined
> to mark these three as ready for 'next'.

Yeah, my "until we resolve" was basically "do people find this Makefile eval trick too gross". And I think the answer is that it's fine.

-Peff
Previous: Junio C Hamano
Message 13 of 13 in “use `curl-config --cflags`”
  1. 0/2 use `curl-config --cflags`Jeff King, Mar 26, 2020
  2. 1/2 Makefile: avoid running curl-config multiple timesJeff King, Mar 26, 2020
  3. 2/2 Makefile: use curl-config --cflagsJeff King, Mar 26, 2020
  4. Junio C HamanoMar 27, 2020
  5. Johannes SchindelinApr 4, 2020
  6. Makefile: avoid running curl-config unnecessarilyJeff King, Apr 4, 2020
  7. Eric SunshineApr 5, 2020
  8. Jeff KingApr 5, 2020
  9. Eric SunshineApr 5, 2020
  10. Johannes SchindelinApr 5, 2020
  11. Johannes SchindelinApr 5, 2020
  12. Junio C HamanoApr 15, 2020
  13. Jeff KingApr 15, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.