From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 05 Apr 2020 22:12:53 GMT
Subject: Re: [PATCH] Makefile: avoid running curl-config unnecessarily
Message-ID: <nycvar.QRO.7.76.6.2004060012120.46@tvgsbejvaqbjf.bet>
In-Reply-To: <CAPig+cR_ViZ2GWSs=grT=5bzQq44w+AAbXFsZaM_-CVMCELXQw@mail.gmail.com>

Hi,

On Sat, 4 Apr 2020, Eric Sunshine wrote:

> On Sat, Apr 4, 2020 at 10:58 AM Jeff King <peff@peff.net> wrote:
> > This is our first use of eval in the Makefile, but that goes back to GNU
> > make v3.80, which is from 2002. I think that should be OK.
>
> Upon reading this, I was worried that it might trip up Mac OS which
> has (often very) old versions of tools, but it's alright in this case,
> as Apple ships GNU 'make' 3.81 from 2006.

I share this concern. It may be more robust, after all, to squelch the
`curl-config` warning specifically in the `Documentation` job of our CI/PR
runs.

Ciao,
Dscho