Re: [PATCH v2 6/8] t7063: drop non-POSIX argument "-ls" from find(1)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 24, 2020, 22:31 UTC
Message-ID: <nycvar.QRO.7.76.6.2003242330540.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqy2rr5amm.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, 23 Mar 2020, Junio C Hamano wrote:

Show 29 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > diff --git a/t/t7063-status-untracked-cache.sh
> > b/t/t7063-status-untracked-cache.sh
> > index 190ae149cf3c..ab7e8b5fea01 100755
> > --- a/t/t7063-status-untracked-cache.sh
> > +++ b/t/t7063-status-untracked-cache.sh
> > @@ -18,7 +18,12 @@ GIT_FORCE_UNTRACKED_CACHE=true
> >  export GIT_FORCE_UNTRACKED_CACHE
> >
> >  sync_mtime () {
> > -       find . -type d -ls >/dev/null
> > +       if test_have_prereq BUSYBOX
> > +       then
> > +               find . -type d -print0 | xargs -0r ls -ld >/dev/null
> > +       else
> > +               find . -type d -ls >/dev/null
> > +       fi
>
> Given that this is only to work around the lazy mtime sync found on
> BSDs, if we were to have any if/then/else, shouldn't we be rather
> doing
>
> 	if test_have_prereq NEEDS_SYNC_MTIME_BECAUSE_WE_ARE_ON_BSD
> 	then
> 		find . -type d -ls >/dev/null
> 	fi
>
> to make it a no-op for most everybody (including Windows)?

I like that approach.

Thank you, Dscho